Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests | Refactor Login Test and Reuse Global Authentication Settings #5360

Conversation

dujes8
Copy link

@dujes8 dujes8 commented Apr 15, 2024

Changes Made:

  • Refactored the login test
  • Implemented setupAuth functionality, which is now defined globally inside the Playwright configuration (this setup is reused across all test suites)
  • Removed redundant test.use calls from individual test suites

Benefits:

  • Eliminated the need for unnecessary test.use calls inside each test suite
  • Centralized authentication setup, improving code organization and reducing redundancy

Additional:

  • Fix failing 'Document public link revoke' test (expect was placed on the wrong place inside test)

@dujes8 dujes8 force-pushed the enhancement/reusable-authentication-setup branch 2 times, most recently from d2b0fe3 to a3ceb19 Compare April 15, 2024 07:59
@dujes8 dujes8 force-pushed the enhancement/reusable-authentication-setup branch from 8ea3c4a to c611470 Compare April 15, 2024 16:28
Signed-off-by: duje qa <dujeqa@gmail.com>
Signed-off-by: duje qa <dujeqa@gmail.com>
This reverts commit 7f9e76f.

Signed-off-by: duje qa <dujeqa@gmail.com>
Signed-off-by: duje qa <dujeqa@gmail.com>
Signed-off-by: duje qa <dujeqa@gmail.com>
Signed-off-by: duje qa <dujeqa@gmail.com>
Signed-off-by: duje qa <dujeqa@gmail.com>
@dujes8 dujes8 force-pushed the enhancement/reusable-authentication-setup branch from a40ac56 to 0b06523 Compare April 15, 2024 20:38
@dujes8 dujes8 closed this May 26, 2024
@dujes8 dujes8 deleted the enhancement/reusable-authentication-setup branch May 26, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants