Toasts #1
Open
Toasts #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
hcharley
commented
Jan 24, 2019
•
hcharley
commented
…p#976) Should have been written as `onExited` as `onExit` is not an event.
docs(Readme): Update dependency versions
Media will now more smartly determine the tag is no tag is provided. It will use other attirbutes to determine which tag makes sense. having an href only makes sense on an anchor, so it will use an anchor tag when an href is present Ref reactstrap#979
This adds .focus() directly on the component so a 'standard' is good enough to call .focus() on
This makes it easier to use submit as if the component was a raw form (via 'standard' )
Allow addMultipleEventListeners to handle single values for element and events
This adds shows a tooltip on focus and hides it when out of focus. Also adds the ability to close tooltip using the escape key. Adds `role='tooltip'` to the tooltip. Fixes reactstrap#1012
Via `<Popover trigger="manual" isInteractive />`. Changed semantics for `trigger="manual"`: hide popover when clicking outside target element *and*, depending on the new `isInteractive` prop, outside the popover itself. Closes reactstrap#1349
…eactstrap#1364) adds propType `fade=true` to PopperContent used in Tooltip and Popover. Default hide delay is changed from 250 to 0 to match bootstrap. popperClassName, used for displaying the popper, is separated from classNames. BREAKING CHANGE: Popover and Tooltip will now fade in and out (like bootstrap's default). To get the previous behavior use fade={false} Closes reactstrap#363
* Fixes 'TypeError: t[(n - 1)] is undefined at [...].handleTab' JavaScript exception
The function `DOMElement` in `utils.js` throws a `ReferenceError` in non-DOM environments such as Node, due to the fact that it references `Element` on the right-hand side of an `instanceof` check, which is (most probably) undefined in non-DOM environments. This pull request adds a small shim for the `Element` object in order to prevent `DOMElement` from throwing an error if `Element` is not defined.
Boolean states should be set with the previous state to avoid async state change issues.
Add the fade prop to the props list for the Alert component docs.
…s… (reactstrap#1410) Currently the `next` and `previous` props on the `PaginationLink` component have default carets that symbolize `first` and `last`. I added new props for `first` and `last` in order to have both features for navigating to any of these. BREAKING CHANGE: Now the `next` and `previous` props are displaying single carets instead of double caret. To get the old style, use `first` and `last` props instead of `previous` and `next` respectfully and set `aria-label` to `Next` or `Previous`.
* Added htmlFor prop for CustomInput * Added proptype, examples
…p#1423) * Use callback in setState when referencing the previous state * Use callback in setState when referencing the previous state
This PR adds a `scrollable` prop to `Modal` which applies the `modal-dialog-scrollable` class which was added in Bootstrap 4.3.0. [Here](https://getbootstrap.com/docs/4.3/components/modal/#scrolling-long-content) is the relevant section of the Bootstrap documentation for reference.
…eactstrap#1426) For Popovers/Tooltips with trigger="click" or trigger="legacy", touches on mobile were triggering touchstart and then click, which caused them to open briefly and then immediately close. This removes the touchstart event handling to fix behaviour on mobile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.