Remove Reporter/Message scheme #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanderkamp
commented
May 8, 2023
Comment on lines
-25
to
+26
| "socket.io": "^4.6.1", | ||
| "socket.io-client": "^4.6.1", | ||
| "socket.io": "^4.2.0", | ||
| "socket.io-client": "^4.2.0", |
There was a problem hiding this comment.
I downgrade socket.io back to 4.2.0 so that we can get debug messages in the browser if we want. See socketio/socket.io-client#1516
mvanderkamp
commented
May 8, 2023
mvanderkamp
added
client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recall adding this in order to avoid some pitfalls that I was hitting early in development. It's a good idea to serialize, but this approach was over-engineered and made the code much more confusing than it needed to be, and was also ultimately limiting.
I've replaced it with simple
toJSONmethods on the base classes. Socket IO will call these methods automatically when it finds them.Closes #16