Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PS 0.15.4 #40

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Upgrade to PS 0.15.4 #40

wants to merge 4 commits into from

Conversation

CGenie
Copy link

@CGenie CGenie commented Sep 12, 2022

This removes the deprecated Control.MonadZero monad.

I also used spago internally and found out unnecessary deps and some required one (control, foldable-traversable) so I added them to the bower.json file.

@hdgarrood
Copy link
Owner

Hey, thanks for the PR. It seems like the bower install step isn't working in CI, do you think you could resolve that?

@CGenie
Copy link
Author

CGenie commented Sep 20, 2022

I guess you should try again, I'm not sure how to work with bower, spago is much easier for me, I just copy deps from a working spago env into bower.json.

@CGenie
Copy link
Author

CGenie commented Sep 20, 2022

I don't understand the error about not being able to pull purescript-tuples.

https://github.com/purescript/purescript-tuples

The v7.0.0 tag is there.

@hdgarrood
Copy link
Owner

ECONFLICT means there's a conflict. One of the other dependencies must have a bound on tuples that precludes that version.

@CGenie
Copy link
Author

CGenie commented Sep 20, 2022

OK now when I run bower update I get no resolution questions, I guess this means no conflicts.

@CGenie
Copy link
Author

CGenie commented Sep 20, 2022

Now it throws some error about Test.Main missing.

@hdgarrood
Copy link
Owner

I think this might be a pulp bug - maybe try upgrading pulp?

@hdgarrood
Copy link
Owner

The pulp version is defined in package.json in case that wasn’t clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants