headlamp-plugin: Make the package arg of the build command optional #321
Conversation
We rely on just calling the "headlamp-plugin build" command without any arguments, but the build command expected a positional argument as required, so the default and advised case for building plugins was failing.
illume
force-pushed
the
do_not_require_a_positional_arg_in_headlamp_plugin
branch
7 times, most recently
from
a7ae5d6
to
f299615
Compare
There's an issue with npm v7 looping on dependencies.
illume
force-pushed
the
do_not_require_a_positional_arg_in_headlamp_plugin
branch
from
f299615
to
6cd5a73
Compare
|
interestingly, the CI found a bug when using npm 7. Where npm 7 gets into a loop resolving dependencies, and keeps processing until it runs out of memory. See npm/cli#3359 and npm/cli#3208 There's a work around for running it on CI with npm 7, but users of npm 7 will encounter this bug. I tried updating the plugin dependencies, and still get the issue. There's another work around or two to try(which I will do next)... but ultimately the bug in npm 7 needs fixing (or maybe it's a bug in one of the dependencies). |
Additionally we stop using --link inside test-headlamp-plugin.sh so that it tests more closely what users will run. Previously this would hang when using npm v7.
illume
force-pushed
the
do_not_require_a_positional_arg_in_headlamp_plugin
branch
from
0281ead
to
37ac355
Compare
|
Adding a package-lock.json generated with npm v6 to the template lets npm v7 work. |
|
Probably we should release a new |
There was a problem hiding this comment.
@illume , It all LGTM. The only thing I noticed is that we're not testing the headlamp-plugin build (no argument) which is what failed initially, or maybe I missed it?
|
@joaquimrocha yeah. It's not directly calling |
- print bash commands for easier debugging - improve build test, so it runs headlamp-plugin build
|
The |
joaquimrocha
deleted the
do_not_require_a_positional_arg_in_headlamp_plugin
branch
We rely on just calling the "headlamp-plugin build" command without
any arguments, but the build command expected a positional argument as
required, so the default and advised case for building plugins was
failing.