Add symbol support to the collection option from the association builder #1705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This change allows the association builder to use symbols as arguments for its collection option. Which will then send them to the class implied from the reflection.
E.g.:
Which would essentially result in the same as:
Changes
Previously, passing a symbol to the collection key would result in an undefined method
#to_a
for the given symbol. This includes a check for the value being a symbol, which then sends the given symbol to the reflection klass, which, returning an object that responds to#to_a
fits in easily with the current code.Reasoning
Passing the collection argument for the association builder in the view requires a reference to the class. The proposed change allows for a more loose relation between the view and your class names, allowing for more reusability.
Known issues
Notes
This is my first contribution and I have but passing knowledge of the code base. I'd appreciate an honest review and feedback and would love to dig into it more if needed. Thanks!