Skip to content

readme: update depgraph #662

readme: update depgraph

readme: update depgraph #662

Triggered via push January 27, 2024 07:14
Status Success
Total duration 5m 56s
Artifacts

pr.yml

on: push
hearth-test
5m 17s
hearth-test
hearth-clippy
2m 7s
hearth-clippy
hearth-rustfmt
18s
hearth-rustfmt
kindling-build
30s
kindling-build
kindling-clippy
39s
kindling-clippy
kindling-rustfmt
14s
kindling-rustfmt
Matrix: hearth-build
Fit to window
Zoom out
Zoom in

Annotations

51 warnings
kindling-rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, LoliGothick/rustfmt-check@master. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
kindling-rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
kindling-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
kindling-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
kindling-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
kindling-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
hearth-rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, LoliGothick/rustfmt-check@master. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
hearth-rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
hearth-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
hearth-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
hearth-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
hearth-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
kindling-build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, Swatinem/rust-cache@v2.2.0, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
kindling-build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
kindling-clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Swatinem/rust-cache@v2.2.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
accessing first element with `resp.1.get(0)`: kindling/host/src/canvas.rs#L49
warning: accessing first element with `resp.1.get(0)` --> kindling/host/src/canvas.rs:49:18 | 49 | cap: resp.1.get(0).unwrap().clone(), | ^^^^^^^^^^^^^ help: try: `resp.1.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default
accessing first element with `resp.1.get(0)`: kindling/host/src/canvas.rs#L49
warning: accessing first element with `resp.1.get(0)` --> kindling/host/src/canvas.rs:49:18 | 49 | cap: resp.1.get(0).unwrap().clone(), | ^^^^^^^^^^^^^ help: try: `resp.1.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default
accessing first element with `DEBUG_DRAW_FACTORY .request((), &[]) .1.get(0)`: kindling/host/src/debug_draw.rs#L51
warning: accessing first element with `DEBUG_DRAW_FACTORY .request((), &[]) .1.get(0)` --> kindling/host/src/debug_draw.rs:51:18 | 51 | cap: DEBUG_DRAW_FACTORY | __________________^ 52 | | .request((), &[]) 53 | | .1 54 | | .get(0) | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first help: try | 51 ~ cap: DEBUG_DRAW_FACTORY 52 + .request((), &[]) 53 + .1.first() |
accessing first element with `DEBUG_DRAW_FACTORY .request((), &[]) .1.get(0)`: kindling/host/src/debug_draw.rs#L51
warning: accessing first element with `DEBUG_DRAW_FACTORY .request((), &[]) .1.get(0)` --> kindling/host/src/debug_draw.rs:51:18 | 51 | cap: DEBUG_DRAW_FACTORY | __________________^ 52 | | .request((), &[]) 53 | | .1 54 | | .get(0) | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first help: try | 51 ~ cap: DEBUG_DRAW_FACTORY 52 + .request((), &[]) 53 + .1.first() |
accessing first element with `resp.1.get(0)`: kindling/host/src/terminal.rs#L47
warning: accessing first element with `resp.1.get(0)` --> kindling/host/src/terminal.rs:47:18 | 47 | cap: resp.1.get(0).unwrap().clone(), | ^^^^^^^^^^^^^ help: try: `resp.1.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
accessing first element with `resp.1.get(0)`: kindling/host/src/terminal.rs#L47
warning: accessing first element with `resp.1.get(0)` --> kindling/host/src/terminal.rs:47:18 | 47 | cap: resp.1.get(0).unwrap().clone(), | ^^^^^^^^^^^^^ help: try: `resp.1.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
accessing first element with `resp.get(0)`: kindling/host/src/time.rs#L56
warning: accessing first element with `resp.get(0)` --> kindling/host/src/time.rs:56:35 | 56 | Self(RequestResponse::new(resp.get(0).unwrap().clone())) | ^^^^^^^^^^^ help: try: `resp.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
accessing first element with `resp.get(0)`: kindling/host/src/time.rs#L56
warning: accessing first element with `resp.get(0)` --> kindling/host/src/time.rs:56:35 | 56 | Self(RequestResponse::new(resp.get(0).unwrap().clone())) | ^^^^^^^^^^^ help: try: `resp.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
accessing first element with `resp.get(0)`: kindling/host/src/time.rs#L77
warning: accessing first element with `resp.get(0)` --> kindling/host/src/time.rs:77:35 | 77 | Self(RequestResponse::new(resp.get(0).unwrap().clone())) | ^^^^^^^^^^^ help: try: `resp.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
accessing first element with `resp.get(0)`: kindling/host/src/time.rs#L77
warning: accessing first element with `resp.get(0)` --> kindling/host/src/time.rs:77:35 | 77 | Self(RequestResponse::new(resp.get(0).unwrap().clone())) | ^^^^^^^^^^^ help: try: `resp.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
hearth-clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: Swatinem/rust-cache@v2.2.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
returning the result of a `let` binding from a block: core/runtime/src/connection.rs#L89
warning: returning the result of a `let` binding from a block --> core/runtime/src/connection.rs:89:9 | 87 | let conn = Arc::new(conn); | -------------------------- unnecessary `let` binding 88 | 89 | conn | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 87 ~ 88 | 89 ~ Arc::new(conn) |
usage of `contains_key` followed by `insert` on a `HashMap`: core/runtime/src/connection.rs#L100
warning: usage of `contains_key` followed by `insert` on a `HashMap` --> core/runtime/src/connection.rs:100:13 | 100 | / if exports.contains_key(&id) { 101 | | // cap is already exported, so drop this reference 102 | | table.dec_ref(handle).unwrap(); 103 | | } else { ... | 112 | | self.send_local_op(op); 113 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry = note: `#[warn(clippy::map_entry)]` on by default help: try | 100 ~ if let std::collections::hash_map::Entry::Vacant(e) = exports.entry(id) { 101 + // cap needs to be exported 102 + let cap = table.wrap_handle(handle).unwrap(); 103 + let perms = cap.get_permissions().bits(); 104 + let perms = hearth_schema::Permissions::from_bits_retain(perms); 105 + let op = LocalCapOperation::DeclareCap { id, perms }; 106 + let revoked = false; 107 + let export = Export { cap, revoked }; 108 + e.insert(export); 109 + self.send_local_op(op); 110 + } else { 111 + // cap is already exported, so drop this reference 112 + table.dec_ref(handle).unwrap(); 113 + } |
returning the result of a `let` binding from a block: core/runtime/src/connection.rs#L89
warning: returning the result of a `let` binding from a block --> core/runtime/src/connection.rs:89:9 | 87 | let conn = Arc::new(conn); | -------------------------- unnecessary `let` binding 88 | 89 | conn | ^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 87 ~ 88 | 89 ~ Arc::new(conn) |
usage of `contains_key` followed by `insert` on a `HashMap`: core/runtime/src/connection.rs#L100
warning: usage of `contains_key` followed by `insert` on a `HashMap` --> core/runtime/src/connection.rs:100:13 | 100 | / if exports.contains_key(&id) { 101 | | // cap is already exported, so drop this reference 102 | | table.dec_ref(handle).unwrap(); 103 | | } else { ... | 112 | | self.send_local_op(op); 113 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry = note: `#[warn(clippy::map_entry)]` on by default help: try | 100 ~ if let std::collections::hash_map::Entry::Vacant(e) = exports.entry(id) { 101 + // cap needs to be exported 102 + let cap = table.wrap_handle(handle).unwrap(); 103 + let perms = cap.get_permissions().bits(); 104 + let perms = hearth_schema::Permissions::from_bits_retain(perms); 105 + let op = LocalCapOperation::DeclareCap { id, perms }; 106 + let revoked = false; 107 + let export = Export { cap, revoked }; 108 + e.insert(export); 109 + self.send_local_op(op); 110 + } else { 111 + // cap is already exported, so drop this reference 112 + table.dec_ref(handle).unwrap(); 113 + } |
very complex type used. Consider factoring parts into `type` definitions: core/runtime/src/runtime.rs#L63
warning: very complex type used. Consider factoring parts into `type` definitions --> core/runtime/src/runtime.rs:63:15 | 63 | finalize: Box<dyn FnOnce(Box<dyn Any>, &mut RuntimeBuilder) + Send>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
you should consider adding a `Default` implementation for `RuntimeBuilder`: core/runtime/src/runtime.rs#L84
warning: you should consider adding a `Default` implementation for `RuntimeBuilder` --> core/runtime/src/runtime.rs:84:5 | 84 | / pub fn new() -> Self { 85 | | let lump_store = Arc::new(LumpStoreImpl::new()); 86 | | let asset_store = AssetStore::new(lump_store.clone()); 87 | | let (service_start_tx, service_start_rx) = unbounded_channel(); ... | 105 | | } 106 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 82 + impl Default for RuntimeBuilder { 83 + fn default() -> Self { 84 + Self::new() 85 + } 86 + } |
very complex type used. Consider factoring parts into `type` definitions: core/runtime/src/runtime.rs#L63
warning: very complex type used. Consider factoring parts into `type` definitions --> core/runtime/src/runtime.rs:63:15 | 63 | finalize: Box<dyn FnOnce(Box<dyn Any>, &mut RuntimeBuilder) + Send>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
you should consider adding a `Default` implementation for `RuntimeBuilder`: core/runtime/src/runtime.rs#L84
warning: you should consider adding a `Default` implementation for `RuntimeBuilder` --> core/runtime/src/runtime.rs:84:5 | 84 | / pub fn new() -> Self { 85 | | let lump_store = Arc::new(LumpStoreImpl::new()); 86 | | let asset_store = AssetStore::new(lump_store.clone()); 87 | | let (service_start_tx, service_start_rx) = unbounded_channel(); ... | 105 | | } 106 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 82 + impl Default for RuntimeBuilder { 83 + fn default() -> Self { 84 + Self::new() 85 + } 86 + } |
use of a fallible conversion when an infallible one could be used: core/ipc/src/lib.rs#L35
warning: use of a fallible conversion when an infallible one could be used --> core/ipc/src/lib.rs:35:28 | 35 | match path.clone().try_into() { | ^^^^^^^^ help: use: `into` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
use of a fallible conversion when an infallible one could be used: core/ipc/src/lib.rs#L44
warning: use of a fallible conversion when an infallible one could be used --> core/ipc/src/lib.rs:44:15 | 44 | match TryInto::<PathBuf>::try_into(path.clone()) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `Into::into` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
hearth-test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, Swatinem/rust-cache@v2.2.0, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
hearth-test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
hearth-test: main/ctl/src/main.rs#L99
function `get_daemon` is never used
hearth-test: main/ctl/src/main.rs#L105
function `hash_map_to_ordered_vec` is never used
hearth-test
`hearth-ctl` (bin "hearth-ctl" test) generated 2 warnings
hearth-build (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, Swatinem/rust-cache@v2.2.0, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
hearth-build (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
hearth-build (ubuntu-latest): main/ctl/src/main.rs#L99
function `get_daemon` is never used
hearth-build (ubuntu-latest): main/ctl/src/main.rs#L105
function `hash_map_to_ordered_vec` is never used
hearth-build (ubuntu-latest)
`hearth-ctl` (bin "hearth-ctl" test) generated 2 warnings
hearth-build (macos-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, Swatinem/rust-cache@v2.2.0, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
hearth-build (macos-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
hearth-build (macos-latest): main/ctl/src/main.rs#L99
function `get_daemon` is never used
hearth-build (macos-latest): main/ctl/src/main.rs#L105
function `hash_map_to_ordered_vec` is never used
hearth-build (macos-latest)
`hearth-ctl` (bin "hearth-ctl" test) generated 2 warnings