Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set Monday as first day of week #623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abykovsk
Copy link

@abykovsk abykovsk commented Feb 16, 2021

Added option to set Monday as first day of week

@mattpulver
Copy link
Contributor

Thank you for the PR.

Few thoughts on this:

  • In general we prefer to stay away from configuration options that produce different results. This makes it harder to debug query results from customers that may have different settings.
  • There are other contexts of what it means to be the beginning of a week. For example EXTRACT(WEEK ...) has a separate meaning for what the first day of the week is, which remains unaffected, that this setting needs to be differentiated from in the --help message.
  • This is replicated with EXTRACT(ISODOW FROM timestamp) - 1. Would this suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants