Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[console] Use the git commit ID for the version #2201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[console] Use the git commit ID for the version #2201

wants to merge 1 commit into from

Conversation

opdavies
Copy link
Contributor

@opdavies opdavies commented May 3, 2016

This uses the git tag for the version, and adds the number of commits ahead and the commit ID if you are using a version that has commits since the last tag.

This should make debugging easier as it's much clearer which version a user is running, and also there's no need to manually increase the version number each time.

This results in output like this:

10:41 DrupalConsole (use-git-version) php drupal.phar --version
Drupal Console version 1.0.0-alpha2-1-g3481b8b

@itsdarrylnorris
Copy link
Contributor

👍 for this....

@jmolivas
Copy link
Member

jmolivas commented May 5, 2016

Not sure how this may affect the self-update command

@opdavies
Copy link
Contributor Author

opdavies commented May 5, 2016

@jmolivas It doesn't affect it on the drupal-vm-generator project. It still works as expected.

@jmolivas jmolivas modified the milestone: nice-to-have May 18, 2016
@enzolutions
Copy link
Contributor

I tested the changes and looks good, but I think will be a little confusing for regulars users, will be better is the git hash or last commit is presented as extra information.

@opdavies
Copy link
Contributor Author

In most scenarios, I'd imagine that regular users would download a stable tagged version, in which case that's what they would see - the same as they would now.

@enzolutions
Copy link
Contributor

Uhh @jmolivas how we will differenciate the phar file create for release that the box created for dev or from source as @opdavies mentioned?

@Saphyel
Copy link
Contributor

Saphyel commented Oct 1, 2016

With Github you have the checkbox "This is a pre-release" but I never used it.

@jmolivas
Copy link
Member

jmolivas commented Jun 6, 2017

I tried this approach at the Launcher, since is the project distributed as a phar.

I agree this is helpful for debugging, but I think the hash added the commit could be confusing for users.

@jmolivas jmolivas modified the milestones: nice-to-have, 1.0.0-fixes Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants