Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds aegir support. #3509

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ttadegraaff
Copy link

Hi, this code works for me, and I expect it might work for others too. That said, I'm a beginner in object oriented programming and Drupal 8, so there probably is a nicer way to get this issue fixed. The database settings are created in Drupal\Core\Site\Settings, and this is a final class. As I understand it this makes it impossible to extend. I ended up copying code from Drupal core to drupal console, which is not nice.

The database settings are read from drushrc.php which is located in the site directory (same location as settings.php).

This is how the database settings exist in my drusrc.php:

$options['db_type'] = 'mysql';
$options['db_host'] = 'localhost';
$options['db_port'] = '3306';
$options['db_passwd'] = 'averystrongpass';
$options['db_name'] = 'thedbname';
$options['db_user'] = 'thedbusername';

I expect aegir always makes the settings available in this way in drushrc.php, but I'm not sure. I haven't looked into the aegir project to check how drushrc.php is created. So there is a possibility that in other environments the settings are stored differently. Nor do I know if there are situations where aegir sites have more then 1 database connection, and how this works if so.

@jmolivas jmolivas modified the milestones: 1.1.0, 1.2.0 Sep 3, 2017
@jmolivas jmolivas removed this from the 1.4.0 milestone Dec 5, 2017
@rrooij
Copy link

rrooij commented Apr 9, 2018

Any update on this? @jmolivas

@bserem
Copy link

bserem commented Oct 24, 2019

Shall this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants