Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency typeorm to v0.3.0 (develop) #2193

Merged
merged 10 commits into from
Jun 12, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 18, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
typeorm 0.2.45 -> 0.3.6 age adoption passing confidence

Configuration

πŸ“… Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the type: maintenance Regular maintenance, like updating dependencies label Mar 18, 2022
@renovate renovate bot force-pushed the renovate/develop-typeorm-0.x branch 6 times, most recently from 9ea0956 to 8c6d156 Compare March 20, 2022 18:58
@davidmehren davidmehren force-pushed the renovate/develop-typeorm-0.x branch 2 times, most recently from 2a00917 to 94d48bd Compare April 3, 2022 15:39
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #2193 (2bc6c42) into develop (bfd5dee) will increase coverage by 0.05%.
The diff coverage is 94.73%.

@@             Coverage Diff             @@
##           develop    #2193      +/-   ##
===========================================
+ Coverage    85.66%   85.72%   +0.05%     
===========================================
  Files          144      144              
  Lines         3404     3411       +7     
  Branches       343      343              
===========================================
+ Hits          2916     2924       +8     
+ Misses         461      460       -1     
  Partials        27       27              
Flag Coverage Ξ”
e2e-tests 77.54% <94.73%> (+0.04%) ⬆️
integration-tests 77.19% <89.47%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
src/identity/identity.service.ts 58.62% <0.00%> (ΓΈ)
src/revisions/revisions.service.ts 83.63% <83.33%> (+0.30%) ⬆️
src/auth/auth.service.ts 82.41% <100.00%> (ΓΈ)
src/groups/groups.service.ts 100.00% <100.00%> (ΓΈ)
src/history/history-entry.entity.ts 100.00% <100.00%> (ΓΈ)
src/history/history.service.ts 98.27% <100.00%> (ΓΈ)
src/media/media.service.ts 81.25% <100.00%> (+1.04%) ⬆️
src/notes/alias.service.ts 98.64% <100.00%> (ΓΈ)
src/notes/notes.service.ts 96.36% <100.00%> (ΓΈ)
src/permissions/note-group-permission.entity.ts 100.00% <100.00%> (ΓΈ)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update bfd5dee...2bc6c42. Read the comment docs.

@davidmehren
Copy link
Member

While tests are green now, we should probably wait until nestjs/typeorm#1233 is merged and released.

@davidmehren davidmehren self-assigned this Apr 3, 2022
@davidmehren davidmehren force-pushed the renovate/develop-typeorm-0.x branch 3 times, most recently from 539bf00 to f59c168 Compare June 5, 2022 20:04
renovate-bot and others added 9 commits June 5, 2022 22:11
Signed-off-by: David Mehren <git@herrmehren.de>
Signed-off-by: David Mehren <git@herrmehren.de>
Signed-off-by: David Mehren <git@herrmehren.de>
For reasons, the typeorm 0.3 broke the find()
method when using relations in the WHERE clause.
This replaces the find method with a query builder.

Signed-off-by: David Mehren <git@herrmehren.de>
For reasons, the typeorm 0.3 broke the find()
method when using relations in the WHERE clause.
This replaces the find method with a query builder.

Signed-off-by: David Mehren <git@herrmehren.de>
For reasons, the typeorm 0.3 broke the find()
method when using relations in the WHERE clause.
This replaces the find method with a query builder.

Signed-off-by: David Mehren <git@herrmehren.de>
For reasons, the typeorm 0.3 broke the find()
method when using relations in the WHERE clause.
This replaces the find method with a query builder.

Signed-off-by: David Mehren <git@herrmehren.de>
For reasons, the typeorm 0.3 started to always return all notes in the database.
This adds a regression test to check for that.

Signed-off-by: David Mehren <git@herrmehren.de>
Signed-off-by: David Mehren <git@herrmehren.de>
Signed-off-by: David Mehren <git@herrmehren.de>
@davidmehren davidmehren force-pushed the renovate/develop-typeorm-0.x branch from 5091e8c to 2bc6c42 Compare June 5, 2022 20:38
@davidmehren davidmehren merged commit 06c39ea into develop Jun 12, 2022
@davidmehren davidmehren deleted the renovate/develop-typeorm-0.x branch June 12, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance Regular maintenance, like updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants