Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Add firefox to CI #4964

Closed
wants to merge 1 commit into from
Closed

Re-Add firefox to CI #4964

wants to merge 1 commit into from

Conversation

mrdrogdrog
Copy link
Member

Component/Part

CI E2E

Description

This PR re-adds firefox to the CI . We had firefox in before but it caused a lot of trouble like crashing and way longer runs. This PR should test if it got any better in the meantime.

Steps

  • Added / updated tests
  • I read the contribution documentation and
    made sure that:
    • My commits are signed-off to accept the DCO.
    • This PR targets the correct branch: master for 1.x & docs, develop for 2.x

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #4964 (22c9655) into develop (f786fe5) will not change coverage.
Report is 5 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4964   +/-   ##
========================================
  Coverage    57.44%   57.44%           
========================================
  Files          405      405           
  Lines        11691    11691           
  Branches       969      969           
========================================
  Hits          6716     6716           
  Misses        4921     4921           
  Partials        54       54           
Flag Coverage Δ
backend 89.32% <ø> (ø)
backend-e2e-tests 75.38% <ø> (ø)
backend-unit-tests 85.72% <ø> (ø)
e2e-tests 75.38% <ø> (ø)
frontend 38.76% <ø> (ø)
frontend-unit-tests 38.76% <ø> (ø)
unit-tests 51.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ErikMichelson
Copy link
Member

The CI failure seems to be a somewhat not deterministic issue (cypress-io/cypress#8611)?

Signed-off-by: Tilman Vatteroth <git@tilmanvatteroth.de>
@mrdrogdrog mrdrogdrog closed this Oct 22, 2023
@mrdrogdrog mrdrogdrog deleted the add-firefox-to-ci branch October 22, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants