Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mongo): added missing exported types #13

Closed
wants to merge 2 commits into from
Closed

fix(mongo): added missing exported types #13

wants to merge 2 commits into from

Conversation

prsnca
Copy link

@prsnca prsnca commented Jul 7, 2021

Which problem is this PR solving?

Short description of the changes

  • Added the new types MongoDBInstrumentationExecutionResponseHook and MongoResponseHookInformation to the export clause on index.ts

@prsnca prsnca requested a review from nozik July 7, 2021 15:06
nozik
nozik requested changes Jul 7, 2021
View reviewed changes
Copy link
Member

@nozik nozik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix linter and create a PR into the otel-contrib repo

@prsnca prsnca force-pushed the add-missing-exported-mongo-types branch 2 times, most recently from a248dcb to 41ceff8 Compare July 8, 2021 07:09
@prsnca prsnca force-pushed the add-missing-exported-mongo-types branch from 41ceff8 to 802690b Compare July 11, 2021 08:18
@nozik nozik closed this Sep 23, 2021
@nozik nozik deleted the add-missing-exported-mongo-types branch September 23, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nozik nozik nozik requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@prsnca @nozik @CptSchnitz