Keymap presentation refinements and underlying restructuring #5635

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

Was not implemented correctly as the order was in the most cases assigned from the values of an HashMap, which does not guarantee order. This applied to when a keymap was both deserialized and merged. Info box body was then being sorted as a function of the fallacious `order` property, and by a method that yielded at worst a time complexity of at least n^2. Furthermore, the body contents were inerted at first by the order of the hash map keys, in which `order` itself was based on. A more reliable predifined sorting order is to be implemented.

Exist under the wrong (possibly just outdated) assumption that command descriptions are written with their KeyTrie name prefixed (Space, View, Goto etc.). For examle: The command `file_picker` is assumed to have the description "Space Open file picker", which is not the case , nor for any other command description.

BTree was being used to store a list of keyevents for a given command. This list was only iterated over twice to in the end be converted to a Vec. Better to just use a Vec from start given the use- case. Temporalily reverts helix-editor#952.

Infobox body was being filled with description then KeyEvent list to only later be iterated over for the purpose of flippingin this order.

Vec<KeyEvent> was being created as an intermediary into Info.rs for it to be converted into a comma separated string. This commit removes this intermediate step but also the single purpose from_keymap public function in Info.rs, as it is no longer needed.

* Descriptive naming and correct use of data structure terminology example translations: keymap.reverse_map -> keymap.command_list keytrienode -> keytrie (struct) search->traverse merge->merge_keytrie keytrie -> keytrienode (enum describing node variants) Leaf -> MappableCommand Sequence -> CommandSequence Node -> KeyTrie (A leaf is a node, and the sequence was also a node. So old naming made absolutely no sense whatsoever.) * Splitting parts of the keymap.rs file into {keytrienode, keytrie, keymaps, tests}.rs. (Should be self-explanatory by looking at the old keymap.rs.) * Removed KeytrieNode enum functions node(&self) -> Option<&KeyTrie> and node_mut(&mut self) -> Option<&mut KeyTrie> from KeyTrieNode as they served no purpose that could not be used from elsewhere. Was also a bit strange to return a "parent struct" from an enum "building block". * Removed getters that could be achieved by making fields public for now. (E.g .root(), .map(), .name()) * Removed keymap.merge() and keytrienode.merge_nodes() All merging could be handled by keytrie.merge() and keymaps.merge_with_default(), unnecessary to have a second unused system that does about the same thing. We also don't want functions that can cause panics as merge_nodes() could. * Initial simplification and formatting of command palette. Formatting is done during the creation of the command lists, removes the need for the creation and and traversal of an intermediary Vec<Vec<String>>. Keyevent formatting changed from "(<space>w<C-q>)" to ["space>w>C-q"]. Clarifying how commands are triggered by moving through submenus/keytries.

For it not to be confused with the upcoming ":help" feature.

This, along with previous commit reverts regression in helix-editor#952

Sort duration calculations averaged to about 0.04 ms when opening the larger infoboxes.

* Elaborated on test descriptions * Removed duplicate unit test * Unified keytrie traversal in tests

* Moved config merging Keymaps to Config * Removed unused default EditorView function

It produces, after all, a Keytrie. It would be a bit like saying: let engine = car!()

By the end of this refactroring it became clear that it was mostly acting as a useless wrapper for KeyTrie.

Root keymap module was empty as old Keymap could be removed. And there was no point anymore in differentiating Keymaps and Keymap.

* Fixed aliased_modes_are_same_in_default_keymap to check for order too. It failed to detect a bug in which the swap_view_* were ordered differently under space-w and c-w.

Sorts by modifier, then by KeyCode category, then by each KeyEvent. Single character alphas are placed before the rest (ex. "space") in KeyCode::Char.

…into keymap-presentation