Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify and clarify config loading #5636

Closed
wants to merge 225 commits into from

Commits on Aug 30, 2022

  1. Configuration menu
    Copy the full SHA
    4e4873d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e9bee3 View commit details
    Browse the repository at this point in the history
  3. fix: cleaner code

    AlexanderBrevig committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    04da5ee View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6ad3fb3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a53a008 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f93e2d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Configuration menu
    Copy the full SHA
    e6e6ec3 View commit details
    Browse the repository at this point in the history
  2. fix: early exit

    AlexanderBrevig committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    ed9aa60 View commit details
    Browse the repository at this point in the history
  3. style: clippy ok

    AlexanderBrevig committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    3da3606 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Configuration menu
    Copy the full SHA
    9359c45 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. fix: remove confirm_local_config

    Alexander Brevig committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    a0f80cd View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Configuration menu
    Copy the full SHA
    11aa418 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8acc1b9 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2022

  1. Configuration menu
    Copy the full SHA
    0f31164 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Configuration menu
    Copy the full SHA
    43470cc View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. Make stickiness configurable

    bbodi committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    671f297 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. docs: fix typos

    AlexanderBrevig committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    84b4f12 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Configuration menu
    Copy the full SHA
    09ea56b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    608687d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    091b3f5 View commit details
    Browse the repository at this point in the history
  4. Simplify labelled command pattern match

    Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
    MattCheely and the-mikedavis committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    56d624e View commit details
    Browse the repository at this point in the history
  5. Add some basic docs

    MattCheely committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3642213 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7804572 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0e6c4af View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Generalised to multiple runtime directories with priorities

    This is an implementation for helix-editor#3346.
    
    Previously, one of the following runtime directories were used:
    
    1. `$HELIX_RUNTIME`
    2. sibling directory to `$CARGO_MANIFEST_DIR`
    3. subdirectory of user config directory
    4. subdirectory of path to helix executable
    
    The first directory provided / found to exist in this order was used as a
    root for all runtime file searches (grammars, themes, queries).
    
    This change lowers the priority of `$HELIX_RUNTIME` so that the user
    config runtime has higher priority. More significantly, all of these
    directories are now searched for runtime files, enabling a user to override
    default or system-level runtime files. If the same file name appears
    in multiple runtime directories, the following priority is now used:
    
    1. sibling directory to `$CARGO_MANIFEST_DIR`
    2. subdirectory of user config directory
    3. `$HELIX_RUNTIME`
    4. subdirectory of path to helix executable
    
    One exception to this rule is that a user can have a `themes`
    directory directly in the user config directory that has higher piority
    to `themes` directories in runtime directories. That behaviour has been
    preserved.
    
    As part of implementing this feature `theme::Loader` was simplified
    and the cycle detection logic of the theme inheritance was improved to
    cover more cases and to be more explicit.
    paul-scott authored and Paul Scott committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    294d1a1 View commit details
    Browse the repository at this point in the history
  2. Removed AsRef usage to avoid binary growth

    paul-scott authored and Paul Scott committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    b642e90 View commit details
    Browse the repository at this point in the history
  3. Health displaying ;-separated runtime dirs

    Paul Scott committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    c4620ff View commit details
    Browse the repository at this point in the history
  4. Changed HELIX_RUNTIME build from src instructions

    Paul Scott committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    5a0a1db View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2023

  1. Configuration menu
    Copy the full SHA
    6d50d7f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37f49f6 View commit details
    Browse the repository at this point in the history
  3. Remove order property of KeyTrie struct:

    Was not implemented correctly as the order was
    in the most cases assigned from the values of
    an HashMap, which does not guarantee order.
    This applied to when a keymap was both
    deserialized and merged.
    
    Info box body was then being sorted as a
    function of the fallacious `order` property,
    and by a method that yielded at worst a time
    complexity of at least n^2.
    
    Furthermore, the body contents were inerted
    at first by the order of the hash map keys,
    in which `order` itself was based on.
    
    A more reliable predifined sorting order is to be
    implemented.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    c748f7c View commit details
    Browse the repository at this point in the history
  4. Infobox: Remove superflous command descripition pruning:

    Exist under the wrong (possibly just outdated)
    assumption that command descriptions are written
    with their KeyTrie name prefixed (Space, View,
    Goto etc.). For examle: The command `file_picker`
    is assumed to have the description
    "Space Open file picker", which is not the case
    , nor for any other command description.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    2c7c4d9 View commit details
    Browse the repository at this point in the history
  5. Keymap infobox: Use Vec in place of BTree:

    BTree was being used to store a list of keyevents
    for a given command. This list was only iterated
    over twice to in the end be converted to a Vec.
    
    Better to just use a Vec from start given the use-
    case. Temporalily reverts helix-editor#952.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    8d35e64 View commit details
    Browse the repository at this point in the history
  6. Keymap infobox: Place in correct order from start:

    Infobox body was being filled with description
    then KeyEvent list to only later be iterated over
    for the purpose of flippingin this order.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    f187f2d View commit details
    Browse the repository at this point in the history
  7. Keymap infobox: Format body from start

    Vec<KeyEvent> was being created as an
    intermediary into Info.rs for it to be
    converted into a comma separated string.
    
    This commit removes this intermediate step
    but also the single purpose from_keymap
    public function in Info.rs, as it is no
    longer needed.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    2a0e9d2 View commit details
    Browse the repository at this point in the history
  8. keymap.rs file splitting, cleanup and descriptive naming:

    * Descriptive naming and correct use of data structure terminology
      example translations:
        keymap.reverse_map -> keymap.command_list
        keytrienode -> keytrie (struct)
          search->traverse
          merge->merge_keytrie
        keytrie -> keytrienode (enum describing node variants)
          Leaf -> MappableCommand
          Sequence -> CommandSequence
          Node -> KeyTrie
          (A leaf is a node, and the sequence was also a node.
    	  So old naming made absolutely no sense whatsoever.)
    * Splitting parts of the keymap.rs file into
      {keytrienode, keytrie, keymaps, tests}.rs.
      (Should be self-explanatory by looking at the old keymap.rs.)
    * Removed KeytrieNode enum functions node(&self) -> Option<&KeyTrie>
      and node_mut(&mut self) -> Option<&mut KeyTrie> from KeyTrieNode
      as they served no purpose that could not be used from elsewhere.
      Was also a bit strange to return a "parent struct" from an enum
      "building block".
    * Removed getters that could be achieved by making fields public for
      now. (E.g .root(), .map(), .name())
    * Removed keymap.merge() and keytrienode.merge_nodes()
      All merging could be handled by keytrie.merge() and
      keymaps.merge_with_default(), unnecessary to have a second
      unused system that does about the same thing.
      We also don't want functions that can cause panics as
      merge_nodes() could.
    * Initial simplification and formatting of command palette.
      Formatting is done during the creation of the command lists,
      removes the need for the creation and and traversal of an
      intermediary Vec<Vec<String>>.
      Keyevent formatting changed from "(<space>w<C-q>)" to ["space>w>C-q"].
      Clarifying how commands are triggered by moving through
      submenus/keytries.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    faec827 View commit details
    Browse the repository at this point in the history
  9. Rename MappableCommand field doc to description:

    For it not to be confused with the upcoming ":help"
    feature.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    d5520e8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    aea10f7 View commit details
    Browse the repository at this point in the history
  11. Infobox: Consistently place lowercase equivalents first

    This, along with previous commit reverts regression in helix-editor#952
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    7f86d01 View commit details
    Browse the repository at this point in the history
  12. Remove infobox optimization suggestion comment:

    Sort duration calculations averaged to about
    0.04 ms when opening the larger infoboxes.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    7935f77 View commit details
    Browse the repository at this point in the history
  13. keymap testing touchups

    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    0482d09 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    6b01af5 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7a8397c View commit details
    Browse the repository at this point in the history
  16. use statement cleanups

    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    546010b View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    036ce4a View commit details
    Browse the repository at this point in the history
  18. Config test cleanup

    * Elaborated on test descriptions
    * Removed duplicate unit test
    * Unified keytrie traversal in tests
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    ac98d82 View commit details
    Browse the repository at this point in the history
  19. Load keymap config consistently

    * Moved config merging Keymaps to Config
    * Removed unused default EditorView function
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    109228b View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    527198a View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    917ca0d View commit details
    Browse the repository at this point in the history
  22. Renamed the keymap! macro to keytrie!:

    It produces, after all, a Keytrie. It would
    be a bit like saying: let engine = car!()
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    8b8fadb View commit details
    Browse the repository at this point in the history
  23. Fix failed cherry picks

    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    7747777 View commit details
    Browse the repository at this point in the history
  24. Removed keymap::Keymap:

    By the end of this refactroring
    it became clear that it was mostly
    acting as a useless wrapper for
    KeyTrie.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    342f794 View commit details
    Browse the repository at this point in the history
  25. Switched keymap::keymaps::Keymaps to keymap::Keymap

    Root keymap module was empty as old Keymap
    could be removed. And there was no point
    anymore in differentiating Keymaps and
    Keymap.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    020c53a View commit details
    Browse the repository at this point in the history
  26. Re-implemented pre-defined orders in keytrie

    * Fixed aliased_modes_are_same_in_default_keymap to check for order too.
      It failed to detect a bug in which the swap_view_* were ordered differently
      under space-w and c-w.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    bda06bc View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    87fc571 View commit details
    Browse the repository at this point in the history
  28. Refine sorting behavior

    Sorts by modifier, then by KeyCode category, then by each KeyEvent.
    Single character alphas are placed before the rest (ex. "space") in KeyCode::Char.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    ecf5d61 View commit details
    Browse the repository at this point in the history
  29. Removed warnings

    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    5e7f4a0 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    c88a817 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    2f0fa30 View commit details
    Browse the repository at this point in the history
  32. Configuration -> LanguageConfigurations

    * Renamed helix_core::syntax::Configuration to
    LanguageConfigurations to dinstiuish it from the other
    types of configurations (theme, keys, editor...),
    and to illustate that it is actually a collection of
    LanguageConfigurations
    
    * (Would similarly want the the LanguagesConfiguarions field
    'language' was renamed to 'language_configurations' but that
    wold interfere with the languages.toml file.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    f3de1fb View commit details
    Browse the repository at this point in the history
  33. user_lang_config -> merged_lang_config

    * Renamed user_lang_config to merged_lang_config, as it includes the default language config.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    55fb3e1 View commit details
    Browse the repository at this point in the history
  34. Enforce separation of concerns in config loading

    * Moved the functions of helix_loader::config (relate only
    to langage config) to helix-loader/lib.rs, and removed
    the file. Mostly to aid in comparison in how the config
    is loaded.
    
    * Moved the functions of helix_core::config to
    helix_core::syntax. This way they're loaded the same way as
    the config.toml. Forces a consistency initialsing language
    config with LanguageConfigurations::default() and ::merged()
    respectively. helix_core::config.rs was then removed.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    34f4380 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    e3ec215 View commit details
    Browse the repository at this point in the history
  36. help.rs: use named parameters

    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    cab5aac View commit details
    Browse the repository at this point in the history
  37. Fix error prone config setup in main

    * Removed config dir check and creation from helix-term main.rs, it
      was being done in the proceeding line with helix_loader::initialize_config_file()
    * Log path setup moved to helix_loader, and setup not done before setting up logging.
      It would create the default log folder even if user specifies thier own log file.
    * Fixed helix_loader::config_file() and log_file() assumption of existing parent directory.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    88bd9cc View commit details
    Browse the repository at this point in the history
  38. Consistent exit handling

    Return Ok(0) to main instead of directly doing
    process::exit(0) on only some of the args. Makes
    it easier to implement special exit handling
    before quitting.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    11248c1 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    3cd0042 View commit details
    Browse the repository at this point in the history
  40. X Setup coherent config loading API

    Does not put project in working state,
    rebase with helix-editor#5635
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    8c5700d View commit details
    Browse the repository at this point in the history
  41. Fix failing test

    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    e6c49ad View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    1dfe855 View commit details
    Browse the repository at this point in the history
  43. Fix failing test

    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    3d52c7a View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    55a64f8 View commit details
    Browse the repository at this point in the history
  45. Fix failing test

    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    1eaaf2d View commit details
    Browse the repository at this point in the history
  46. lib.rs cleanup

    * RUNTIME_DIR now behaves similar to the other
      runtime files
    * merge_toml_values: Moved function explanation
      comment in a function call to its
      documentation.
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    6aec856 View commit details
    Browse the repository at this point in the history
  47. Unify tasks from xtask and helix_loader

    * Wider use relative path replacements by moving xtask::pash to  helix_loader::repo_paths.rs.
    * Wider use of new LanguageConfig load API
    * Minor appalication.rs cleanup
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    5331bb6 View commit details
    Browse the repository at this point in the history
  48. Use unified config loading in docgen and health

    health.rs
    * Removed duplicate clipboard provider writeout.
    * Removed 'all' flag option but added a 'paths' option.
    * Removed check if user config exist or show default
      part as default is always merged with user config.
    
    docgen:
    * removed xtask::helper::lang_config(), using
      LanguageConfiguarions::default() instead.
    * moved xtask::query_check to xtask::main and made it use
      TSFeature.runtime_filename()
    gibbz00 committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    3be034c View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Merge remote-tracking branch 'brevig-local-config/feat-load-local-con…

    …fig' into unify-config
    gibbz00 committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    b9b916d View commit details
    Browse the repository at this point in the history
  2. Touchoups

    * Fix failing integration testing
    * Fix bug in which which local directories were being tested for their
      existence.
    * Fixes helix-editor#5144
    * Ran cargo fmt
    gibbz00 committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    d814356 View commit details
    Browse the repository at this point in the history
  3. Run cargo fmt

    gibbz00 committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    ae6790c View commit details
    Browse the repository at this point in the history
  4. Use description conistenly

    gibbz00 committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    44ad646 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    eaea712 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    abf2f28 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bae26ae View commit details
    Browse the repository at this point in the history
  8. Implement clippy tips

    gibbz00 committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    eccda6e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    64cefce View commit details
    Browse the repository at this point in the history
  10. Implement clippy tips

    gibbz00 committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    bcf3cb0 View commit details
    Browse the repository at this point in the history
  11. Make cargo fmt happy

    gibbz00 committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    2afcfcf View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b8affcc View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Configuration menu
    Copy the full SHA
    c617fd1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3cac825 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7dbacf3 View commit details
    Browse the repository at this point in the history
  4. Unblock helix-editor#5656

    gibbz00 committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    4d02459 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e3dd261 View commit details
    Browse the repository at this point in the history
  6. Fight with cargo fmt round 3

    gibbz00 committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    b4b82b4 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'keymap-presentation' of https://github.com/gibbz00/helix

    …into keymap-presentation
    gibbz00 committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    8c1333a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    58a9cad View commit details
    Browse the repository at this point in the history
  9. Run cargo fmt

    gibbz00 committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    3f760f1 View commit details
    Browse the repository at this point in the history
  10. Merge helix-editor#5411

    Reduced comment some verbosity, the method
    signatures should speak for themselves.
    
    runtime_file -> get_runtime_file
    gibbz00 committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    90926bb View commit details
    Browse the repository at this point in the history
  11. make fmt and clippy happy

    gibbz00 committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    2d463f1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f2afd72 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    1f966d7 View commit details
    Browse the repository at this point in the history
  14. Theme.rs

    * Clarify method signature of newly intrudused path -> find_remaining_path
    * Remove unused self.names()
    * Removed overly verbose comments.
    gibbz00 committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    0b9c2e8 View commit details
    Browse the repository at this point in the history
  15. Create helix_loader::get_first_runtime_dir

    Replaces the get_runtime_dirs().first().expect("...") in helix_loader:::grammar
    gibbz00 committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    e7aee35 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Configuration menu
    Copy the full SHA
    c8dd563 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df49f60 View commit details
    Browse the repository at this point in the history
  3. Remove order property of KeyTrie struct:

    Was not implemented correctly as the order was
    in the most cases assigned from the values of
    an HashMap, which does not guarantee order.
    This applied to when a keymap was both
    deserialized and merged.
    
    Info box body was then being sorted as a
    function of the fallacious `order` property,
    and by a method that yielded at worst a time
    complexity of at least n^2.
    
    Furthermore, the body contents were inerted
    at first by the order of the hash map keys,
    in which `order` itself was based on.
    
    A more reliable predifined sorting order is to be
    implemented.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    69ed135 View commit details
    Browse the repository at this point in the history
  4. Infobox: Remove superflous command descripition pruning:

    Exist under the wrong (possibly just outdated)
    assumption that command descriptions are written
    with their KeyTrie name prefixed (Space, View,
    Goto etc.). For examle: The command `file_picker`
    is assumed to have the description
    "Space Open file picker", which is not the case
    , nor for any other command description.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    10151a9 View commit details
    Browse the repository at this point in the history
  5. Keymap infobox: Use Vec in place of BTree:

    BTree was being used to store a list of keyevents
    for a given command. This list was only iterated
    over twice to in the end be converted to a Vec.
    
    Better to just use a Vec from start given the use-
    case. Temporalily reverts helix-editor#952.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    465c0ef View commit details
    Browse the repository at this point in the history
  6. Keymap infobox: Place in correct order from start:

    Infobox body was being filled with description
    then KeyEvent list to only later be iterated over
    for the purpose of flippingin this order.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    8768bf9 View commit details
    Browse the repository at this point in the history
  7. Keymap infobox: Format body from start

    Vec<KeyEvent> was being created as an
    intermediary into Info.rs for it to be
    converted into a comma separated string.
    
    This commit removes this intermediate step
    but also the single purpose from_keymap
    public function in Info.rs, as it is no
    longer needed.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    b50050b View commit details
    Browse the repository at this point in the history
  8. keymap.rs file splitting, cleanup and descriptive naming:

    * Descriptive naming and correct use of data structure terminology
      example translations:
        keymap.reverse_map -> keymap.command_list
        keytrienode -> keytrie (struct)
          search->traverse
          merge->merge_keytrie
        keytrie -> keytrienode (enum describing node variants)
          Leaf -> MappableCommand
          Sequence -> CommandSequence
          Node -> KeyTrie
          (A leaf is a node, and the sequence was also a node.
    	  So old naming made absolutely no sense whatsoever.)
    * Splitting parts of the keymap.rs file into
      {keytrienode, keytrie, keymaps, tests}.rs.
      (Should be self-explanatory by looking at the old keymap.rs.)
    * Removed KeytrieNode enum functions node(&self) -> Option<&KeyTrie>
      and node_mut(&mut self) -> Option<&mut KeyTrie> from KeyTrieNode
      as they served no purpose that could not be used from elsewhere.
      Was also a bit strange to return a "parent struct" from an enum
      "building block".
    * Removed getters that could be achieved by making fields public for
      now. (E.g .root(), .map(), .name())
    * Removed keymap.merge() and keytrienode.merge_nodes()
      All merging could be handled by keytrie.merge() and
      keymaps.merge_with_default(), unnecessary to have a second
      unused system that does about the same thing.
      We also don't want functions that can cause panics as
      merge_nodes() could.
    * Initial simplification and formatting of command palette.
      Formatting is done during the creation of the command lists,
      removes the need for the creation and and traversal of an
      intermediary Vec<Vec<String>>.
      Keyevent formatting changed from "(<space>w<C-q>)" to ["space>w>C-q"].
      Clarifying how commands are triggered by moving through
      submenus/keytries.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    eb50de1 View commit details
    Browse the repository at this point in the history
  9. Rename MappableCommand field doc to description:

    For it not to be confused with the upcoming ":help"
    feature.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    d74be02 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7192a4e View commit details
    Browse the repository at this point in the history
  11. Infobox: Consistently place lowercase equivalents first

    This, along with previous commit reverts regression in helix-editor#952
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    26adc32 View commit details
    Browse the repository at this point in the history
  12. Remove infobox optimization suggestion comment:

    Sort duration calculations averaged to about
    0.04 ms when opening the larger infoboxes.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    4fb58f7 View commit details
    Browse the repository at this point in the history
  13. keymap testing touchups

    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    d33ff8b View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    958e8bc View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    d0f93ec View commit details
    Browse the repository at this point in the history
  16. use statement cleanups

    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    876885e View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    315fa89 View commit details
    Browse the repository at this point in the history
  18. Config test cleanup

    * Elaborated on test descriptions
    * Removed duplicate unit test
    * Unified keytrie traversal in tests
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    fcf8e6b View commit details
    Browse the repository at this point in the history
  19. Load keymap config consistently

    * Moved config merging Keymaps to Config
    * Removed unused default EditorView function
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    e233a1b View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    4a188d2 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    baf8640 View commit details
    Browse the repository at this point in the history
  22. Renamed the keymap! macro to keytrie!:

    It produces, after all, a Keytrie. It would
    be a bit like saying: let engine = car!()
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    3466209 View commit details
    Browse the repository at this point in the history
  23. Fix failed cherry picks

    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    ff25380 View commit details
    Browse the repository at this point in the history
  24. Removed keymap::Keymap:

    By the end of this refactroring
    it became clear that it was mostly
    acting as a useless wrapper for
    KeyTrie.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5c6c0ed View commit details
    Browse the repository at this point in the history
  25. Switched keymap::keymaps::Keymaps to keymap::Keymap

    Root keymap module was empty as old Keymap
    could be removed. And there was no point
    anymore in differentiating Keymaps and
    Keymap.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    ff6b53f View commit details
    Browse the repository at this point in the history
  26. Re-implemented pre-defined orders in keytrie

    * Fixed aliased_modes_are_same_in_default_keymap to check for order too.
      It failed to detect a bug in which the swap_view_* were ordered differently
      under space-w and c-w.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    aed2e90 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    5edce2e View commit details
    Browse the repository at this point in the history
  28. Refine sorting behavior

    Sorts by modifier, then by KeyCode category, then by each KeyEvent.
    Single character alphas are placed before the rest (ex. "space") in KeyCode::Char.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    0b08e38 View commit details
    Browse the repository at this point in the history
  29. Removed warnings

    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5049e7c View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    4f758ee View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    c224bf3 View commit details
    Browse the repository at this point in the history
  32. Fix failing test

    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    95a2b87 View commit details
    Browse the repository at this point in the history
  33. Run cargo fmt

    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    941624b View commit details
    Browse the repository at this point in the history
  34. Use description conistenly

    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    7735b34 View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    8e1a3da View commit details
    Browse the repository at this point in the history
  36. Implement clippy tips

    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    16e2d74 View commit details
    Browse the repository at this point in the history
  37. Make cargo fmt happy

    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    dc8e463 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    4bfa470 View commit details
    Browse the repository at this point in the history
  39. Fight with cargo fmt round 3

    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    03088b2 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    4bf9f82 View commit details
    Browse the repository at this point in the history
  41. Merge branch 'keymap-presentation' of https://github.com/gibbz00/helix

    …into keymap-presentation
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    eaf883b View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    89936e1 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    816a9dd View commit details
    Browse the repository at this point in the history
  44. Proper runtime directory health diagnostics

    Instead of blurting out, say "does not exist",
    without refererring to which directory the
    diagnostic relates to.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    eb31bd7 View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    fa615c2 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    4af3d1d View commit details
    Browse the repository at this point in the history
  47. merge escaped keymap test

    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    13a9f3e View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    b27f4a5 View commit details
    Browse the repository at this point in the history
  49. cargo fmt

    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    c5e505e View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    8dd2169 View commit details
    Browse the repository at this point in the history
  51. Scrapped FromIterator<InfoboxRow> idea

    Removes the ability to create the Vec using
    with_capacity if I'm not mistaken.
    gibbz00 committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    b8e1ee4 View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    375238f View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. health: add formatter binary

    This adds a new output to --health that displays
    the formatter binary.
    jzelinskie committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    dc06713 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2023

  1. Add prefix position to file args

    A cursor position can now be specified using common prefix notation
    used by vim, nvim, kak, emacs and nano.
    
    eg. `hx +10 Cargo.toml`
    
    This prefix notation also allows the user to set the cursor at the
    end of the file.
    
    eg. `hx +: Cargo.toml`
    
    This allows `hx` to play nicely with other tools that want to open a
    file at a given position using prefix notation.
    
    The existing postfix notation can still be used (`hx Cargo.toml:10`)
    but has been extended to support jumping to the end of a buffer.
    
    eg. `hx Cargo.toml:`
    bheylin committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    1e6c605 View commit details
    Browse the repository at this point in the history
  2. Fix clippies

    bheylin committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    0a75108 View commit details
    Browse the repository at this point in the history
  3. Fix typos

    bheylin committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    461e31f View commit details
    Browse the repository at this point in the history
  4. Fix typos

    bheylin committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    22e491e View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Configuration menu
    Copy the full SHA
    872f01f View commit details
    Browse the repository at this point in the history
  2. Rm assert_matches dep

    bheylin committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    0622cdc View commit details
    Browse the repository at this point in the history
  3. Rm file indexing in tests

    bheylin committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    34ab790 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e480a16 View commit details
    Browse the repository at this point in the history
  5. Merge 'matt-cheely/labels-for-config-menus'

    Changes:
    
    Makes it possible to also add custom descriptions of CommandSequences,
    not only KeyTries and Typable commands. Test have been added for each
    case.
    
    Also, if no arguments are passed to the typaple command, use
    official description. (instead of say :w).
    
    Uses the term description instead of label for consistencies sake.
    "description" key is followed by "exec" for command sequences and
    mappable commands in TOML config.
    gibbz00 committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    8d4626c View commit details
    Browse the repository at this point in the history
  6. Merge branch 'master' of https://github.com/helix-editor/helix into k…

    …eymap-presentation
    gibbz00 committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    a7abb1f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    395bfa6 View commit details
    Browse the repository at this point in the history
  8. fix clippy warnigs

    gibbz00 committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    b06eb3f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0756dd5 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. fix cargo doc warnings

    gibbz00 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    56189c9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f44a348 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b62d9a4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9825ca0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    044e344 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fcbae4b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b69a7d4 View commit details
    Browse the repository at this point in the history
  8. args.rs: move PositionRequest for file readability

    * Moved some helper functions to become associated
      functins of PositionRequest.
    * Increased usage of Self.
    * Moved PositionRequest logic and tests into it's one file.
    gibbz00 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    2665ae8 View commit details
    Browse the repository at this point in the history
  9. load-local-config set to false by default

    Otherwise it becomes impossible to run `hx -c /dev/null`
    gibbz00 committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    7b5b268 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Merge 'bbodi/sticky-config/sticky-config'

    Does not work with pre-existing keytrienodes...
    Will try to check if it work on the unify-config
    branch as I suspect config loading might be the culprit.
    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    b609a02 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c36ba42 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    72e1581 View commit details
    Browse the repository at this point in the history
  4. cargo fmt

    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    ad9bc2a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    34db341 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2d9cea8 View commit details
    Browse the repository at this point in the history
  7. config.rs: clean up tests

    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    68c66ac View commit details
    Browse the repository at this point in the history
  8. fix keytrie on default mappable command override bug

    I had introduced a bug in which it wasn't possible to override
    mappable commands with keytries. Test has been added to catch this miss.
    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    6a81215 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    91d8d92 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    159150b View commit details
    Browse the repository at this point in the history
  11. revert some cleanup of use statements

    ...in the hopes that it simplifies review.
    The changes should have probably be codified into
    `cargo fmt`.
    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    683931a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ec76a96 View commit details
    Browse the repository at this point in the history
  13. improve keymap deserialize error handlig

    Replace two `.expect()` with returning Err.
    Using the let else pattern for this. Only became
    stable in 1.65.0, hence the bump.
    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    e98afd2 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    3a06115 View commit details
    Browse the repository at this point in the history
  15. fix refresh theme bug:

    Probably introduced when merging with helix-editor#3207.
    
    Refreshing config from failed state would not update to set
    theme from default theme. Reason being that theme was being loaded
    before config was being set. One would have to refresh the config twice
    to update the theme as well. This commit changes the refresh order such
    that the config is actually set before refreshing the theme.
    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    27c45ba View commit details
    Browse the repository at this point in the history
  16. clippy lints

    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    f3d102e View commit details
    Browse the repository at this point in the history
  17. unify theme loading pt. 1

    * theme_loader in editor only
    * consistent use of lang_configs_loader
    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    fcd8b31 View commit details
    Browse the repository at this point in the history
  18. unify theme loading pt. 2

    Arcswap for theme_loader can now be removed as Editor is it's sole owner
    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    9bcd089 View commit details
    Browse the repository at this point in the history
  19. unify theme loading pt. 3

    * theme_dirs generation done in helix_loader and not application.rs
    * getting theme directories is done through Editor for now. Goal is to
      unify all set_theme() preperation calls, somewhere. As it is currenply
      duplicated in typed.rs, application.rs, and editor.rs
    
    Toghether these points remove the need to pass down themeloader from
    `Application` to `Editor`.
    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    9de7893 View commit details
    Browse the repository at this point in the history
  20. unify theme loading pt. 4

    Just moved some lines around for a better understanding of what goes
    together with what.
    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    737b856 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    ba7520b View commit details
    Browse the repository at this point in the history
  22. Remove lang_configs_loader field from Appliction

    Main purpose in application.rs was for it to then be passed down to Editor.
    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    692d744 View commit details
    Browse the repository at this point in the history
  23. Unwrap in terminal.size()

    All calls to the function were unwrapping it immediatedly after.
    Where `.expect("couldn't get terminal size")` was duplicated thrice in
    application.rs.
    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    4ba73b3 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    cf9fd51 View commit details
    Browse the repository at this point in the history
  25. Unify true_color detection

    config.load().editor.true_color || crate::true_color() or the like
    is was found a handful of times. Moves the logic of crate::true_color
    to Editor::default() constructor. This allows it to still be overriden
    by user configs whilst also removing the repeated OR expression.
    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    ebe7ddf View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    05d04f3 View commit details
    Browse the repository at this point in the history
  27. Unify theme loading

    * True color support is now looked for once in main.rs, and checked internally in theme upon each theme update.
    * Removes theme::Loader all together
    * Theme errors notified on start-up just like all the other config parse errors.
    gibbz00 committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    1055cd2 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Theme::read_names API cleanup

    * Leverage the existence of helix_loader::theme_dirs
    gibbz00 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    dc1fa33 View commit details
    Browse the repository at this point in the history
  2. Place Impl blocks under stuct declarations

    This commit merely moves around some blocks in theme.rs, making it
    slightly easier to read.
    gibbz00 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    6fde0e1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6335989 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    95b227a View commit details
    Browse the repository at this point in the history
  5. Unify logging

    HELIX_LOG_LEVEL env variable can now also be set in a non integration
    test environment.
    gibbz00 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    d1135f7 View commit details
    Browse the repository at this point in the history
  6. Rename editor::Config to EditorConfig

    Stupidly hard to differentiate it with config::Config.
    gibbz00 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    40a4e3d View commit details
    Browse the repository at this point in the history
  7. add Theme::default

    A step in making it more in line to how the other configs are loaded.
    gibbz00 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    9a2257b View commit details
    Browse the repository at this point in the history
  8. make true color support bool a static

    paves the way for a Default implementation for Theme
    gibbz00 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    eceb19f View commit details
    Browse the repository at this point in the history
  9. Merge Theme::update and new

    gibbz00 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    08a1038 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    73136a9 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    134e8bf View commit details
    Browse the repository at this point in the history
  12. Remove Option wrapper for Config.theme

    Does so by assuming empty string implyies default theme in Theme::new.
    Paves the way to make Config::default() to be derivable.
    gibbz00 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    1678741 View commit details
    Browse the repository at this point in the history
  13. Theme::default impl comment

    gibbz00 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    64eaf09 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    28b60a9 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    b4076e5 View commit details
    Browse the repository at this point in the history
  16. fix clippy lints

    gibbz00 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    d326827 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. custom description refinements

    * Allow override of predifinde infobox descriptions.
    * Make sure that custom description overrider on infoboxes can be done
    without additional remappings of the same keytrie.
    gibbz00 committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    a0d918a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ef96da View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    95a7d26 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    31dc585 View commit details
    Browse the repository at this point in the history