Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for parent argument handling #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

b3j0f
Copy link

@b3j0f b3j0f commented Mar 15, 2023

Pull Request Process

Before submitting a pull request

Be sure you have the latest code in hand. Pull the master branch

Be sure to make test and keep all test pass

Be sure to make tidy so your code style will keep the same

Be sure to make cover-report to see if any line not covered

Don't Rebase git history

General steps for completing this pull request

Checklist

Does your project contributions have steps to follow before being approved? Tests, documentation changing, etc?

Ensure that your pull request has followed all the steps below:

  • Code compilation
  • All tests passing
  • Extended the documentation, if applicable

Description

Ask the contributor to describe his pull request.

This pull request add tests for my previous pull request.

Proposed changes

Ask contributors about why you (or your project maintainers) would accept the pull request. If it solves a previous request, also ask to link to that issue.

Types of changes

Show in a checkbox-style, the expected types of changes your project is supposed to have:

  • New feature
  • Bugfix
  • Improve
  • So on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant