Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environmental module #84

Merged
merged 2 commits into from
May 22, 2024
Merged

Add environmental module #84

merged 2 commits into from
May 22, 2024

Conversation

maxd-nordic
Copy link
Contributor

No description provided.

@maxd-nordic maxd-nordic changed the title wip Add environmental module May 14, 2024
balaji-nordic
balaji-nordic reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@balaji-nordic balaji-nordic left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it necessary to check in the generated code to git? I prefer to keep them in the build folder and not commit them in.

@maxd-nordic maxd-nordic marked this pull request as ready for review May 15, 2024 14:12
@maxd-nordic
Copy link
Contributor Author

Was it necessary to check in the generated code to git? I prefer to keep them in the build folder and not commit them in.

Necessary is a strong word, but it is in line with how it's done in NCS. We can refactor this if needed.

@simensrostad
Copy link
Contributor

Was it necessary to check in the generated code to git? I prefer to keep them in the build folder and not commit them in.

Necessary is a strong word, but it is in line with how it's done in NCS. We can refactor this if needed.

I think we should avoid checking in generated code, its not necessary. Its up to use to decide. For instance for wifi prov stuff I didn't do it.

I think you also can do some tricks that prevents the code from being generated in source, but rather in build. That is supported when using protobuf.

@balaji-nordic
Copy link
Contributor

I think you also can do some tricks that prevents the code from being generated in source, but rather in build. That is supported when using protobuf.

This is doable using cmake. I can help out if needed.

@maxd-nordic maxd-nordic force-pushed the environmental branch 2 times, most recently from b183cc9 to 79044a0 Compare May 21, 2024 15:39
@maxd-nordic
Copy link
Contributor Author

I think you also can do some tricks that prevents the code from being generated in source, but rather in build. That is supported when using protobuf.

This is doable using cmake. I can help out if needed.

done

@maxd-nordic maxd-nordic force-pushed the environmental branch 3 times, most recently from 64b440a to d2072f8 Compare May 22, 2024 09:10
@maxd-nordic
app: add environmental module
76b7e61 
This patch adds a module to report gas sensor
measurements using the BSEC library.

Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
@maxd-nordic
app: transport: use message subscriber
b57ae82 
This patch changes the transport module's
subscriber to a message subscriber.

Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@maxd-nordic maxd-nordic merged commit 1c96ec1 into main May 22, 2024
5 checks passed
@maxd-nordic maxd-nordic deleted the environmental branch May 22, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balaji-nordic balaji-nordic Awaiting requested review from balaji-nordic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxd-nordic @simensrostad @balaji-nordic