Add option to exclude tags #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanato
requested changes
Sep 4, 2023
zalsader
force-pushed
the
exclude-tags
branch
2 times, most recently
from
4c725b1
to
a6ac56e
Compare
Signed-off-by: Zuhair AlSader <zuhair@koor.tech>
zalsader
force-pushed
the
exclude-tags
branch
from
a6ac56e
to
8f85898
Compare
|
Added |
|
@cpanato could you please take a look again? |
|
thanks. Before we merge this, is it possible to show test evidence that it is working? also show the a test that the normal case still works thanks |
|
Closing because I no longer have access to the original repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code for
lookup_latest_tagfinds the latest tag, whether it was generated by helm or not. This option allows excluding a certain pattern of tags. e.g.v*to exclude version tags.