HIP: Server Side Apply support #312
Open
+161
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjenkins8
force-pushed
the
server_side_apply_hip
branch
from
95e4e59
to
3c11723
Compare
gjenkins8
changed the title
gjenkins8
commented
Aug 10, 2023
hips/hip-00XX.md
Outdated
|
|
||
| #### Special | ||
|
|
||
| - `--dry-run=client` doesn't work with SSA enabled |
There was a problem hiding this comment.
@mattfarina points out that this will make it difficult for user's to preview changes
gjenkins8
commented
Aug 10, 2023
hips/hip-00XX.md
Outdated
|
|
||
| #### Conflicts and forcing | ||
|
|
||
| It is possible when Helm upgrades a chart, that there will be a field conflict with another field manager. In this case, Helm should report the error to the user. |
There was a problem hiding this comment.
TODO: verify we can abort atomically across multiple objects (Ian Z points this out)
gjenkins8
commented
Aug 10, 2023
|
@gjenkins8 I think this HIP as written would apply to the release secret itself, too. Am I correct with this understanding? We're running into the issue that the release secret is > 1MB in https://github.com/community-tooling/charts because of the |
gjenkins8
force-pushed
the
server_side_apply_hip
branch
3 times, most recently
from
83adec1
to
c1b29c9
Compare
Signed-off-by: George Jenkins <gvjenkins@gmail.com>
gjenkins8
force-pushed
the
server_side_apply_hip
branch
from
e1e4d73
to
9048d85
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIP for Helm to support SSA