fix(doc): helm list go sdk doc #1499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ithrael <wh01096045@gmail.com>
Ithrael
force-pushed
the
fix/helm-list-go-sdk-doc
branch
from
72b43ff
to
f745acc
Compare
|
@gjenkins8 @yxxhero please review the PR |
|
@BigStupideer @angellk please review the PR, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: helm/helm#12269
helm sdk simple-example
This document is incorrect, according to this document, helm sdk can't list all charts. I would like to make a modification in the helm project so that helm sdk does not need to invoke client.SetStateMask(), but it is very difficult. Because helm sdk can filter through client.All=True, and can also filter through client.StateMask=129. I can't meet these two situations with very small modifications. In addition, I noticed that in the source code of helm, after setting client.All=True, it also needs to invoke client.SetStateMask(). https://github.com/helm/helm/blob/main/cmd/helm/list.go#L237 So, I decided to modify the documentation and add client.SetStateMask() to the examples provided in the helm sdk documentation.