Skip to content

Commit

Permalink
Revert "It appears we never got to this block below. Quick rec by Far…
Browse files Browse the repository at this point in the history
…ina. Untested if necessary"

This reverts commit f616a01.

Removing for now until we know we need it.

Signed-off-by: Scott Rigby <scott@r6by.com>
  • Loading branch information
scottrigby committed Jan 12, 2022
1 parent 3dc9930 commit 39792b5
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions pkg/downloader/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,8 @@ func (m *Manager) resolveRepoNames(deps []*chart.Dependency) (map[string]string,
missing := []string{}
for _, dd := range deps {
// Don't map the repository, we don't need to download chart from charts directory
if dd.Repository == "" {
// When OCI is used there is no Helm repository
if dd.Repository == "" || registry.IsOCI(dd.Repository) {
continue
}
// if dep chart is from local path, verify the path is valid
Expand All @@ -594,8 +595,6 @@ func (m *Manager) resolveRepoNames(deps []*chart.Dependency) (map[string]string,
continue
}

// See https://helm.sh/docs/topics/registries/#specifying-dependencies
// See createTestingMetadataForOCI()
if registry.IsOCI(dd.Repository) {
reposMap[dd.Name] = dd.Repository
continue
Expand Down

0 comments on commit 39792b5

Please sign in to comment.