Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Properly invalidate client after CRD install
As the CRDs are installed before the capabilities are gathered, the current call to invalidate the discovery client is premature and expensive. What actually is required is an invalidation of the REST mapper, as otherwise the Helm install action may later on fail with a `resource mapping not found` error. More specifically when the caller of the action is making use of a persisting[1] `RESTClientGetter`. Which is not something done by the Helm CLI (albeit it could, and this would potentially save quite some resources?). But is a default configuration offered by the Helm SDK via `kube.New` when a nil value is provided as the `getter`. [1]: https://github.com/kubernetes/cli-runtime/blob/v0.26.2/pkg/genericclioptions/config_flags.go#L118 Signed-off-by: Hidde Beydals <hidde@hhh.computer>
- Loading branch information