Skip to content

Commit

Permalink
Add support for installing on Windows via Cygwin
Browse files Browse the repository at this point in the history 
Signed-off-by: Ioan Indreias <indreias@gmail.com>
  • Loading branch information
@indreias
indreias committed Nov 24, 2021
1 parent 98c4ccf commit 7993393
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/get-helm-3
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ initOS() {

case "$OS" in
# Minimalist GNU for Windows
mingw*) OS='windows';;
mingw*|cygwin*) OS='windows';;
esac
}

Expand Down

3 comments on commit 7993393

@dandosi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this commit is not enough to install on Cygwin. The script also fails on a line with sudo. For that reason, one has to start the script with --no-sudo on Cygwin:
./get_helm.sh --no-sudo

@indreias
Copy link
Contributor Author

@indreias indreias commented on 7993393 Mar 15, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dandosi not sure what are you asking for but in case your installation do not have sudo command than it is clear that you have to use --no-sudo option.

and, btw, there is no get_helm.sh script but get-helm-3

@dandosi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, Cygwin does not have a sudo command, which is why I commented the above.

Please sign in to comment.