Skip to content

Commit

Permalink
Pass http getter as pointer in tests
Browse files Browse the repository at this point in the history
Signed-off-by: Matthias Fehr <matthias@monostream.com>
  • Loading branch information
matthiasfehr committed Feb 22, 2022
1 parent 2acda0c commit 7d22040
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions pkg/getter/httpgetter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -402,24 +402,24 @@ func TestHTTPGetterTarDownload(t *testing.T) {
func TestHttpClientInsecureSkipVerify(t *testing.T) {
g := HTTPGetter{}
g.opts.url = "https://localhost"
verifyInsecureSkipVerify(t, g, "Blank HTTPGetter", false)
verifyInsecureSkipVerify(t, &g, "Blank HTTPGetter", false)

g = HTTPGetter{}
g.opts.url = "https://localhost"
g.opts.caFile = "testdata/ca.crt"
verifyInsecureSkipVerify(t, g, "HTTPGetter with ca file", false)
verifyInsecureSkipVerify(t, &g, "HTTPGetter with ca file", false)

g = HTTPGetter{}
g.opts.url = "https://localhost"
g.opts.insecureSkipVerifyTLS = true
verifyInsecureSkipVerify(t, g, "HTTPGetter with skip cert verification only", true)
verifyInsecureSkipVerify(t, &g, "HTTPGetter with skip cert verification only", true)

g = HTTPGetter{}
g.opts.url = "https://localhost"
g.opts.certFile = "testdata/client.crt"
g.opts.keyFile = "testdata/client.key"
g.opts.insecureSkipVerifyTLS = true
transport := verifyInsecureSkipVerify(t, g, "HTTPGetter with 2 way ssl", true)
transport := verifyInsecureSkipVerify(t, &g, "HTTPGetter with 2 way ssl", true)
if len(transport.TLSClientConfig.Certificates) <= 0 {
t.Fatal("transport.TLSClientConfig.Certificates is not present")
}
Expand All @@ -428,7 +428,7 @@ func TestHttpClientInsecureSkipVerify(t *testing.T) {
}
}

func verifyInsecureSkipVerify(t *testing.T, g HTTPGetter, caseName string, expectedValue bool) *http.Transport {
func verifyInsecureSkipVerify(t *testing.T, g *HTTPGetter, caseName string, expectedValue bool) *http.Transport {
returnVal, err := g.httpClient()

if err != nil {
Expand Down

0 comments on commit 7d22040

Please sign in to comment.