Skip to content

Commit

Permalink
Change underscore (_) back to plus (+) for Helm
Browse files Browse the repository at this point in the history
Signed-off-by: Scott Rigby <scott@r6by.com>
  • Loading branch information
scottrigby committed Jan 12, 2022
1 parent ee382eb commit 808a2d1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion internal/experimental/registry/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,9 @@ func (c *Client) Tags(ref string) ([]string, error) {

var tagVersions []*semver.Version
for _, tag := range registryTags {
tagVersion, err := semver.StrictNewVersion(tag)
// Change underscore (_) back to plus (+) for Helm
// See https://github.com/helm/helm/issues/10166
tagVersion, err := semver.StrictNewVersion(strings.ReplaceAll(tag, "_", "+"))
if err == nil {
tagVersions = append(tagVersions, tagVersion)
}
Expand Down

0 comments on commit 808a2d1

Please sign in to comment.