Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Readiness Check for statefulsets using partitioned rolling update. #11774

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Fixes Readiness Check for statefulsets using partitioned rolling update. #11774

merged 2 commits into from
Mar 30, 2023

Commits on Feb 2, 2023

  1. Fixes Readiness Check for statefulsets using partitioned rolling update. 

    Fixes helm#11773

This change updates readiness check in ready.go to correctly
account for statefulsets that are utilizing a partitioned upgrade.
These statefulsets only upgrade a subset of the managed pods with each call
to helm upgrade. This causes the upgrade to legitimately hit the condition where
sts.status.CurrentRevision != sts.Status.UpdateRevision which causes helm to mark
the upgrade has failed when in fact it is successful.

This change fixes that behavior to only check when partition is unspecified or 0.

Signed-off-by: Aman Nijhawan <anijhawan@yugabyte.com>
    @amannijhawan
    amannijhawan committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    4b3db5b View commit details
    Browse the repository at this point in the history

  2. Adding a unit test to verify that partitioned rolling upgrade for a s… 

    …tatefulset works.

Signed-off-by: Aman Nijhawan <anijhawan@yugabyte.com>
    @amannijhawan
    amannijhawan committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    9f26a36 View commit details
    Browse the repository at this point in the history