Fix chart install error when CWD contains files or dirs of same name as chart #13009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt present in CWD. Signed-off-by: Alex Somesan <alex.somesan@gmail.com>
pull-request-size
bot
added
the
size/L
This was referenced May 7, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a more exhaustive check for the presence, in the current working directory of a local copy of the chart being installed.
Previously this detection was done with a simple
os.Stat()call which would yield false positives even when an empty file of the same name as the chart was present, which leads to the installation failing.These changes preserve the original behaviour that prioritises the local copy over the remote one.
Special notes for your reviewer:
Fixes issue #13008
If applicable: