New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12987: test toToml int conversion #13012
base: main
Are you sure you want to change the base?
Conversation
97795db
to
34e14f8
Compare
34e14f8
to
8d055e2
Compare
// Ensure that toToml processes integers as ints, and not floats | ||
name: "template with toToml processing an integer", | ||
cmd: fmt.Sprintf("template '%s'", "testdata/testcharts/issue-12987"), | ||
golden: "output/issue-12987.txt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this test fails
"moby/templates/test5": "", | ||
"moby/templates/test6": "bar = 9\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while this test passes
}, { | ||
tpl: `{{ toToml . }}`, | ||
expect: "bar = 9.0\n", | ||
vars: map[string]float32{"bar": 9.0}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this test passes
This is failing due to builds not passing. Is it possible you are out of sync with this branch? I will try to build and run it. Also you are missing DCO, that isn't optional. |
What this PR does / why we need it:
Special notes for your reviewer:
If applicable: