Windows arm64 build #13029
Merged
Windows arm64 build #13029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
asmitde
force-pushed
the
asmitde/windows-arm64-build
branch
from
aa9e8a1
to
a579f50
Compare
Signed-off-by: Asmit De <asmit.de@outlook.com>
Signed-off-by: Asmit De <asmit.de@outlook.com>
asmitde
force-pushed
the
asmitde/windows-arm64-build
branch
from
a579f50
to
f615c1a
Compare
|
I've replicated the behaviour specified in the PR. Compiling on OSX 14.4 using: Then transferred the |
|
Should pkg/plugin/plugin_test.go need an additional line after 95 to include arm64 windows? Then update the remainder of the file to handle the new architecure |
mattfarina
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for Windows arm64 builds.
Special notes for your reviewer:
Cross compiled Helm for windows/arm64 on Surface Pro X (ARM64) in WSL2 with Go v1.22.2 linux/arm64. Tested the windows/arm64 binary in the Windows 11 powershell environment.
If applicable: