fix(tiller): correctly sort PodDisruptionBudget objects before pods that might use them #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultimateboy
force-pushed
the
sort-pdb
branch
3 times, most recently
from
9894722
to
3dd9588
Compare
…hat might use them Signed-off-by: Matt Tucker <ultimateboy@gmail.com>
|
It turns out, the error I was really running into was caused by an upstream bug: kubernetes/kubernetes#63757 that was fixed in k8s 1.12.0 Basically, the The only way to work around this is to delete the PodDisruptionBudget object before you do a helm upgrade.... or update to k8s 1.12.0. I still think this pull request is useful, but it turns out not to be the real solution. |
splisson
pushed a commit
to splisson/helm
that referenced
this pull request
Dec 6, 2018
…hat might use them (helm#4769) Signed-off-by: Matt Tucker <ultimateboy@gmail.com> Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
splisson
pushed a commit
to splisson/helm
that referenced
this pull request
Dec 6, 2018
…hat might use them (helm#4769) Signed-off-by: Matt Tucker <ultimateboy@gmail.com> Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
splisson
pushed a commit
to splisson/helm
that referenced
this pull request
Dec 6, 2018
…hat might use them (helm#4769) Signed-off-by: Matt Tucker <ultimateboy@gmail.com>
splisson
pushed a commit
to splisson/helm
that referenced
this pull request
Dec 6, 2018
…hat might use them (helm#4769) Signed-off-by: Matt Tucker <ultimateboy@gmail.com>
1 task
hickeyma
pushed a commit
that referenced
this pull request
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, using a pod disruption budget causes errors like this: