Add descriptions to repo completions #9421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/L
marckhouzam
force-pushed
the
feat/compDescPart2
branch
from
bd70e1a
to
024bb3e
Compare
helm-bot
added
size/M
marckhouzam
changed the title
|
Now that we are on Cobra 1.2.1, I was able to add descriptions for repo name completions in all cases. |
Ref: HIP 0008 When completing a repo name, extra information will be shown. For example: $ helm repo remove <TAB> bitnami -- https://charts.bitnami.com/bitnami center -- https://repo.chartcenter.io stable -- https://kubernetes-charts.storage.googleapis.com $ helm install myrelease <TAB> ./ -- Relative path prefix to local chart / -- Absolute path prefix to local chart bitnami/ -- https://charts.bitnami.com/bitnami center/ -- https://repo.chartcenter.io file:// -- Chart local URL prefix grafana/ -- https://grafana.github.io/helm-charts https:// http:// -- Chart URL prefix oteemocharts/ -- https://oteemo.github.io/charts prometheus-community/ -- https://prometheus-community.github.io/helm-charts stable/ -- https://charts.helm.sh/stable $ helm show all <TAB> bitnami -- https://charts.bitnami.com/bitnami center -- https://repo.chartcenter.io stable -- https://kubernetes-charts.storage.googleapis.com Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
marckhouzam
force-pushed
the
feat/compDescPart2
branch
from
024bb3e
to
c727207
Compare
|
I've rebased this PR to get #9990. The new descriptions added with this PR can now be tested with bash. |
bacongobbler
approved these changes
Aug 20, 2021
|
Thanks @bacongobbler ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is part 2 of the implementation of HIP 008: https://github.com/helm/community/blob/master/hips/hip-0008.md
It is a follow-up to #9243
This PR adds descriptions to Helm's custom completions for repository names. Note that with #9990 these descriptions are available for every shell.
For example:
Special notes for your reviewer:
The remaining aspects of HIP 0008 are:
<repo>-charts.txtfile, which currently does not contain enough information to provide a description for chart namesIf applicable: