Skip to content

Commit

Permalink
Drop support for Node <4
Browse files Browse the repository at this point in the history
Node 0.10 was EOL'd (end-of-lifed) on 2016-10-31 and Node 0.12 was EOL'd
on 2016-12-31.

This is arguably a backwards-incompatible change, but I think it's safe
because:

1. No affected Node versions are supported. Node 0.10 support ended on
   2016-10-31; Node 0.12 support ended on 2016-12-31. (Node 4 is not
   supported either but that deprecation was less than a year ago, on
   2018-04-01.)
2. If you're using an old Node version, you'll get a warning but you'll
   still be able to install things.
3. ...unless you've set the `engine-strict` configuration value (which
   is unset by default). If you've enabled this obscure setting on an
   old Node version, you will be unable to install new Helmet versions.
   I don't expect to receive a single report about this, but it is the
   one part of this change that is technically breaking.
  • Loading branch information
EvanHahn committed Mar 10, 2019
1 parent 9f13f08 commit a49cec3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased
### Changed
- Changelog is now in the [Keep A Changelog](https://keepachangelog.com/) format
- Dropped support for Node <4

### Deprecated
- `helmet.hsts`'s `setIf` option has been deprecated and will be removed in `hsts@3`. See [helmetjs/hsts#22](https://github.com/helmetjs/hsts/issues/22) for more
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"url": "git://github.com/helmetjs/helmet.git"
},
"engines": {
"node": ">= 0.10.0"
"node": ">=4.0.0"

This comment has been minimized.

Copy link
@XhmikosR

XhmikosR Mar 11, 2019

you could shorten this to >=4 :)

This comment has been minimized.

Copy link
@EvanHahn

EvanHahn Mar 11, 2019

Author Member

I was pretty sure I could do that but didn't see that documented anywhere. Is that terser functionality documented anywhere?

If not, I'd prefer to stick with this because it's more explicit.

This comment has been minimized.

Copy link
@XhmikosR

XhmikosR Mar 11, 2019

It's not related to terser, this is just semver ;)

},
"dependencies": {
"depd": "2.0.0",
Expand Down

0 comments on commit a49cec3

Please sign in to comment.