Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ci error in issue.2118.yaml #319

Merged
merged 1 commit into from
Aug 26, 2022
Merged

fix ci error in issue.2118.yaml #319

merged 1 commit into from
Aug 26, 2022

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Aug 25, 2022

Signed-off-by: yxxhero aiopsclub@163.com

Fixed: #318

@yxxhero
Copy link
Member Author

yxxhero commented Aug 26, 2022

done @mumoshu

@yxxhero yxxhero force-pushed the fix_ci branch 2 times, most recently from 16b12d2 to 66527e5 Compare August 26, 2022 01:17
@yxxhero
fix ci error in issue.2118.yaml
e887da1 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
Copy link
Member Author

yxxhero commented Aug 26, 2022

@mumoshu git::https://github.com/argoproj/argo-cd.git@manifests/crds?ref=master is not ok.

@yxxhero
Copy link
Member Author

yxxhero commented Aug 26, 2022

@mumoshu ready to merge.

mumoshu
mumoshu approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in the meantime! Thanks. But we'd better move those CRDs to a more reliable location so that it won't fail randomly due to external changes.

@mumoshu mumoshu merged commit 7434872 into main Aug 26, 2022
@mumoshu mumoshu deleted the fix_ci branch August 26, 2022 01:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mumoshu mumoshu mumoshu approved these changes

@itscaro itscaro Awaiting requested review from itscaro itscaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI error in test/intergration/issue.2118.yaml
2 participants
@yxxhero @mumoshu