Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --interactive option to sync, delete and destroy / Remove --interactive from global options #328

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Aug 27, 2022

Signed-off-by: yxxhero aiopsclub@163.com

  1. add interactive in sync
  2. remove --interactive in global options

not all subcommand has interactive mode.

Fixed: #324

@mumoshu

Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
Copy link
Member Author

yxxhero commented Aug 27, 2022

@mumoshu Ready to review. WDYT?

Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
Copy link
Member Author

yxxhero commented Aug 27, 2022

@mumoshu done

  1. add interactive in sync
  2. remove --interactive in global options
  3. in cmd/apply.go applyImpl.ApplyOptions --> applyOptions reduce the code.

Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for enhancing it!

@mumoshu mumoshu changed the title add interactive in sync & remove --interactive in global options Add --interactive option to sync, delete and destroy / Remove --interactive from global options Aug 28, 2022
@mumoshu mumoshu merged commit 9284d17 into main Aug 28, 2022
@mumoshu mumoshu deleted the 324-helmfile-sync-interactive-does-not-ask-for-confirmation-before-applying branch August 28, 2022 01:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helmfile sync --interactive does not ask for confirmation before applying
2 participants