Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --skip-needs regression introduced in v0.145.0 #342

Merged

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Aug 31, 2022

Signed-off-by: yxxhero aiopsclub@163.com

fix --skip-needs issue

fixed: #339

@yxxhero yxxhero linked an issue Aug 31, 2022 that may be closed by this pull request
@yxxhero
Copy link
Member Author

yxxhero commented Aug 31, 2022

@mumoshu

@yxxhero yxxhero added this to the 0.145.5 milestone Sep 6, 2022
@stek29
Copy link
Contributor

stek29 commented Sep 12, 2022

@mumoshu @itscaro PTAL :)

@yxxhero
Copy link
Member Author

yxxhero commented Sep 12, 2022

@stek29 do you meet this?

@stek29
Copy link
Contributor

stek29 commented Sep 12, 2022

@yxxhero well I'm waiting for next release with list speedup, and it's blocked by this PR, so yes

@yxxhero
Copy link
Member Author

yxxhero commented Sep 12, 2022

@stek29 yeah. when this Pr is merged. we will create a new release. Thanks very much. thanks for your works. looking forword your more and more work for helmfile.

Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero yxxhero force-pushed the 339-introduction-of-skip-needs-results-in-breaking-change branch from 6293bab to bf323b4 Compare September 12, 2022 10:04
@yxxhero
Copy link
Member Author

yxxhero commented Sep 12, 2022

@mumoshu done. sorry for this issue.

@yxxhero
Copy link
Member Author

yxxhero commented Sep 13, 2022

@mumoshu and this is ok.

Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it!!

@mumoshu mumoshu changed the title fix --skip-needs issue Fix --skip-needs regression added in v0.145.0 Sep 14, 2022
@mumoshu mumoshu changed the title Fix --skip-needs regression added in v0.145.0 Fix --skip-needs regression introduced in v0.145.0 Sep 14, 2022
@yxxhero yxxhero merged commit ade8e81 into main Sep 14, 2022
@yxxhero yxxhero deleted the 339-introduction-of-skip-needs-results-in-breaking-change branch September 14, 2022 00:50
@yxxhero
Copy link
Member Author

yxxhero commented Sep 14, 2022

@stek29 enjoy 0.145.5. Thanks very much.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduction of --skip-needs results in breaking change
3 participants