feat: honor concurrency in withPreparedCharts #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stek29
force-pushed
the
concurrency-preparedcharts
branch
from
a9c4f55
to
edfc18b
Compare
Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>
stek29
force-pushed
the
concurrency-preparedcharts
branch
from
edfc18b
to
822b7b2
Compare
|
@stek29 Please fix ci error. |
|
@yxxhero I don't see how test failure has anything to do with my proposed changes – it fails locally too for me, even when running tests on master. are you sure it's up to me to fix and it has anything to do with my changes? maybe tests are just flaky/broken for external contributors? |
|
Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>
stek29
force-pushed
the
concurrency-preparedcharts
branch
from
09b3b4e
to
a56303b
Compare
|
@yxxhero please approve running test, I've tried to implement a fix. |
yxxhero
reviewed
Sep 2, 2022
yxxhero
reviewed
Sep 2, 2022
|
@stek29 Thanks very much. |
yxxhero
reviewed
Sep 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #341
this PR also adds --concurrency flag to
depscommand.