feat: dont prepare on list

[stek29]

This changes list command so it doesn't run withPreparedCharts, and just lists releases instead.

See discussion #344 for reasoning.

This might break environments which relied on list having to build everything - I can add a backwards compatible opt flag if that's an issue

changelog note for this PR

Add --skip-charts flag to list subcommand, to only list releases without preparing and templating charts for them

[stek29]

@yxxhero PTAL, list being slow is really painful for us :(

[yxxhero]

@stek29 do you test this on your use case? Thanks very much.

[yxxhero]

@stek29

This might break environments which relied on list having to build everything - I can add a backwards compatible opt flag if that's an issue

I think so. please do it.

[stek29]

@yxxhero I did test it with my use case – our CI pipeline generation stage now runs in under 10 seconds, and it was taking about 5 minutes before, and about 1.5 minutes when running helmfile itself in parallel.

[yxxhero]

@stek29 It's a good idea. @mumoshu

[yxxhero]

@stek29 can we add a option for this logic. example --skip-chart?

[yxxhero]

@stek29 Please fix conflic.

[stek29]

@yxxhero I'll fix the conflict and add a bool flag later today or tomorrow morning (so in next 24h or so)

[stek29]

@yxxhero should be ready now.

do you track changelog notes anywhere, should I add a note to changelog describing new flag?

[yxxhero]

@stek29 yes. Please add describtion for this flag for the next release changelog.

[yxxhero]

with-prepared-charts? why not skip-prepared-charts

[yxxhero]

@stek29 ping

[stek29]

@stek29 yes. Please add describtion for this flag for the next release changelog.

how do I do that?

with-prepared-charts? why not skip-prepared-charts

because function is named withPreparedCharts, to keep naming consistent.
should I change to skip- instead? also, imo skip-prepared-charts doesn't sound right to me, how about skip-charts or skip-prepare-charts, or even skip-with-prepared-charts instead?

[yxxhero]

@stek29 skip-charts is better? WDYT?

[yxxhero]

@stek29 add changelog describtion in issue describtion.

[stek29]

@yxxhero but there's no issue - you don't accept issues for feature requests, only discussions

[yxxhero]

@stek29 PR describtion is ok.

[stek29]

@yxxhero i've fixed linting error, changed flag to --skip-charts, and added changelog note example to PR description

[stek29]

@yxxhero I've also just noticed there was another test for List, in app_test.go

I've moved it to app_list_test.go and made it run with and without prepared charts

[yxxhero]

@stek29 Thanks very much.

[stek29]

@yxxhero I've changed WithPreparedCharts to SkipCharts in code too

[yxxhero]

@yxxhero I've changed WithPreparedCharts to SkipCharts in code too

@stek29 Thanks very much. I will review when I'm free.

[yxxhero]

LGTM

[yxxhero]

@stek29 Thanks very much. This is a great optimization.

[yxxhero]

@stek29 can you create a PR for update https://github.com/helmfile/helmfile/blob/main/docs/index.md#cli-reference. Thanks very much.

[stek29]

@yxxhero sure, will do

any chance to get a release with this mr, btw?

[yxxhero]

@stek29 wait for you doc PR. Thanks very much.