Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrent exit code issue introduced in v0.145.0 #359

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Fix incorrent exit code issue introduced in v0.145.0 #359

merged 1 commit into from
Sep 14, 2022

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Sep 13, 2022 •
edited

Signed-off-by: yxxhero aiopsclub@163.com

fix incorrent exit code

fixed: #358

  1. remove all github.com/urfave/cli deps
  2. fix cobra error

@mumoshu

@yxxhero yxxhero linked an issue Sep 13, 2022 that may be closed by this pull request
incorrect exit code #358
Closed
@yxxhero yxxhero added this to the 0.145.5 milestone Sep 13, 2022
@yxxhero
fix incorrent exit code
76bf995 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero
Copy link
Member Author

yxxhero commented Sep 13, 2022

@mumoshu done

mumoshu
mumoshu approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your effort!

@mumoshu mumoshu changed the title fix incorrent exit code Fix incorrent exit code issue added in v0.145.0 Sep 14, 2022
@mumoshu mumoshu changed the title Fix incorrent exit code issue added in v0.145.0 Fix incorrent exit code issue introduced in v0.145.0 Sep 14, 2022
@yxxhero yxxhero merged commit 3ff98c0 into main Sep 14, 2022
@yxxhero yxxhero deleted the 358-incorrect-exit-code branch September 14, 2022 00:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mumoshu mumoshu mumoshu approved these changes

@itscaro itscaro Awaiting requested review from itscaro itscaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.145.5
Development

Successfully merging this pull request may close these issues.

incorrect exit code
2 participants
@yxxhero @mumoshu