remove flags.Parse in cobra

[yxxhero]

Signed-off-by: yxxhero aiopsclub@163.com

remove flags.Parse in cobra

flags. Parse refers to the code of the helm, but I found that some parameter parsing exceptions would occur, so I removed this logic

[root@devops helmfile]# go run main.go template --args "-s templates/deployment.yaml"
environment will be: mplates/deployment.yaml [it's error]
args will be: -s templates/deployment.yaml

fixed: #299

[yxxhero]

@mumoshu

[mumoshu]

This LGTM!

But I think this revealead another issue for me. Let me explain- so if you run ./helmfile --log-level=debug template -f path/to/your/helmfile.yaml --args "-s templates/deployment.yaml" you'll see from helmfile debug logs that it isn't passing the specified args to any helm commands ran by helmfile.
--args has never worked reliably, but this seems worse than before. Perhaps we somehow broke it when we migrated to cobra? 🤔

You can merge this, but we'd better investigate since when and how --args isn't working in that case.

Note though, long flags in --args seem to "work". I figure it out by passing an invalid long flag to --args, like helmfile --log-level=debug template -f path/to/helmfile.yaml --args "--aaa. It did fail with Error: unknown flag: --aaa as helm-template does not support the flag. So unlike the -s case, the flag has been passed to helm-template.

Perhaps it's just that short flags like -s path/to/template isn't working when specified within --args?

[yxxhero]

@mumoshu ok. I will look at the logic of args in detail.