Fix not to ignore diff selector when it matched nothing #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
force-pushed
the
fix-diff-selector-not-working-on-installed-false
branch
from
11a44f3
to
3bc34f1
Compare
mumoshu
commented
Sep 19, 2022
| }) | ||
| }) | ||
|
|
||
| t.Run("shows no diff on already uninstalled selected release", func(t *testing.T) { |
There was a problem hiding this comment.
This test had been failing before the fix, due to a bug that helmfile completely ignored the selector when the selector along with installed filter returned no releases.
Fixes #327 Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
mumoshu
force-pushed
the
fix-diff-selector-not-working-on-installed-false
branch
from
3bc34f1
to
c90cace
Compare
yxxhero
deleted the
fix-diff-selector-not-working-on-installed-false
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327
Signed-off-by: Yusuke Kuoka ykuoka@gmail.com