Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ci.yaml and use helm 3.10.0 #383

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Update ci.yaml and use helm 3.10.0 #383

merged 1 commit into from
Oct 5, 2022

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Sep 21, 2022 •
edited

Update ci.yaml and use helm 3.10.0

@yxxhero
add helm 3.10.0 in ci
3cfa0d8 
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero yxxhero changed the title Update ci.yaml and use 3.10.0 Update ci.yaml and use helm 3.10.0 Sep 22, 2022
@yxxhero
Copy link
Member Author

yxxhero commented Sep 22, 2022

@mumoshu

mumoshu
mumoshu approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update!
Probably we'd better cut a new Helmfile release ASAP so that folks can start testing if the new Helm version works fine with Helmfile?

@mumoshu mumoshu merged commit 65cc374 into main Oct 5, 2022
@mumoshu mumoshu deleted the yxxhero-patch-1 branch October 5, 2022 02:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mumoshu mumoshu mumoshu approved these changes

@itscaro itscaro Awaiting requested review from itscaro itscaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yxxhero @mumoshu