Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: upgrade gopkg.in/yaml.v2 to gopkg.in/yaml.v3 #396

Merged
merged 4 commits into from
Oct 5, 2022
Merged

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Sep 27, 2022

Signed-off-by: yxxhero aiopsclub@163.com

fix: #394

bump: upgrade gopkg.in/yaml.v2 to gopkg.in/yaml.v3

@yxxhero yxxhero mentioned this pull request Sep 27, 2022
@yxxhero yxxhero marked this pull request as draft September 29, 2022 22:32
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero yxxhero marked this pull request as ready for review October 3, 2022 02:46
Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero yxxhero force-pushed the bump_yaml_v3 branch 3 times, most recently from 5f8aade to f6fd754 Compare October 3, 2022 09:24
@yxxhero
Copy link
Member Author

yxxhero commented Oct 3, 2022

@mumoshu done. Added more test for the yaml overwrite feature.

Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for the update!

@yxxhero yxxhero merged commit bffa048 into main Oct 5, 2022
@yxxhero yxxhero deleted the bump_yaml_v3 branch October 5, 2022 02:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow key overrides
2 participants