imprv: convert hyphen included in repo name to underbar with gatherOCIUsernamePassword. #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mugioka
commented
Oct 3, 2022
…IUsernamePassword. Most shells do not support hyphens in environment variables. However, there are cases where you may want to include hyphens in the repository name. Therefore, I have included a process in `gatherOCIUsernamePassword` to replace hyphens with underbar. Signed-off-by: mugioka <okamugi0722@gmail.com>
mugioka
force-pushed
the
imprv/convert-hyphen-included-in-repo-name-to-underbar
branch
from
771d782
to
a42c14e
Compare
|
@mugioka good idea. Please add some test for this case. |
|
OK. i will add some tests. |
Signed-off-by: mugioka <okamugi0722@gmail.com>
mugioka
force-pushed
the
imprv/convert-hyphen-included-in-repo-name-to-underbar
branch
from
b223c62
to
68728ef
Compare
mugioka
deleted the
imprv/convert-hyphen-included-in-repo-name-to-underbar
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most shells do not support hyphens in environment variables.
However, there are cases where you may want to include hyphens in the repository name.
Therefore, I have included a process in
gatherOCIUsernamePasswordto replace hyphens with underbar.Signed-off-by: mugioka okamugi0722@gmail.com