Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reuse-values args for diff apply and sync #411

Merged
merged 1 commit into from
Oct 8, 2022

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Oct 5, 2022

Signed-off-by: yxxhero aiopsclub@163.com

fix: #221

add reuse-values args for diff apply and sync

@yxxhero yxxhero linked an issue Oct 5, 2022 that may be closed by this pull request
@yxxhero yxxhero force-pushed the add_reuse_values_support_by_args branch from b77fa73 to 169a5ac Compare October 5, 2022 09:16
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero yxxhero force-pushed the add_reuse_values_support_by_args branch from 169a5ac to 4ce7cfe Compare October 5, 2022 09:22
@junnplus
Copy link

junnplus commented Oct 5, 2022

@yxxhero Big thanks, I tested this branch locally and it worked as expected.

@yxxhero
Copy link
Member Author

yxxhero commented Oct 5, 2022

@mumoshu

@yxxhero yxxhero changed the title add reuse-values args for diff apply and sync feat: add reuse-values args for diff apply and sync Oct 7, 2022
Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mumoshu mumoshu merged commit 21c28ca into main Oct 8, 2022
@mumoshu mumoshu deleted the add_reuse_values_support_by_args branch October 8, 2022 05:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm upgrade flag "--reuse-values" via ARGS has no effect
3 participants