Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more clear error message and Environment info for template #413

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Oct 6, 2022

feat: add more clear error message and Environment info for template

fix: #409

@yxxhero yxxhero linked an issue Oct 6, 2022 that may be closed by this pull request
@yxxhero yxxhero force-pushed the 409-write-values-and-output-file-templating-error branch from 4d6ea12 to f809580 Compare October 6, 2022 00:50
@yxxhero yxxhero force-pushed the 409-write-values-and-output-file-templating-error branch from f809580 to bf15d6f Compare October 6, 2022 00:55
pkg/state/state.go Outdated Show resolved Hide resolved
Co-authored-by: Yusuke Kuoka <ykuoka@gmail.com>
Signed-off-by: yxxhero <aiopsclub@163.com>
@yxxhero yxxhero force-pushed the 409-write-values-and-output-file-templating-error branch from e118f63 to 4ad02d3 Compare October 6, 2022 12:02
@yxxhero
Copy link
Member Author

yxxhero commented Oct 6, 2022

@mumoshu done

Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mumoshu mumoshu merged commit e06abe4 into main Oct 7, 2022
@mumoshu mumoshu deleted the 409-write-values-and-output-file-templating-error branch October 7, 2022 01:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write-values and output file templating error
2 participants