feat: retrieve repository's username/password from environment #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinleturc
force-pushed
the
feature-resolve-helm-auth-from-env
branch
from
c2829b6
to
224cc21
Compare
|
@kevinleturc Please fix the ci error. And add some tests for your PR. Thanks very much. |
kevinleturc
force-pushed
the
feature-resolve-helm-auth-from-env
branch
from
224cc21
to
9f3362f
Compare
|
@yxxhero, this is my first time with go, I should have fixed the CI errors and added some tests for the feature. Tell me if it's still missing something. Thanks. |
|
@kevinleturc please fix lint error. |
kevinleturc
force-pushed
the
feature-resolve-helm-auth-from-env
branch
from
9f3362f
to
1259168
Compare
|
Sorry for the lint, I've just fixed it with |
|
@kevinleturc yes. It's enough. Thanks for your work on this feature. |
|
If I understand correctly |
Signed-off-by: Kevin Leturc <kevinleturc@users.noreply.github.com>
kevinleturc
force-pushed
the
feature-resolve-helm-auth-from-env
branch
from
1259168
to
422852d
Compare
|
@yxxhero we should be good now, I fixed Thanks for your time! |
|
@kevinleturc good work. keep going on. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make possible to retrieve username/password from the environment for Helm repositories, like it is done for OCI registries.
Related to roboll/helmfile#1629