Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlite): fix error-prone last inserted id #61

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

jhomarolo
Copy link
Contributor

Fixes #59 (comment)

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • Remember to check if code coverage decrease, if so, please implement the necessary tests

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #61 (8103193) into master (31a394a) will decrease coverage by 1.28%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   98.00%   96.71%   -1.29%     
==========================================
  Files           3        3              
  Lines         150      152       +2     
==========================================
  Hits          147      147              
- Misses          3        5       +2     
Impacted Files Coverage Δ
src/repository.js 94.18% <0.00%> (-2.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a394a...8103193. Read the comment docs.

@jhomarolo jhomarolo merged commit 6d17054 into herbsjs:master Jul 18, 2022
@jhomarolo jhomarolo added the bug Something isn't working label Jul 18, 2022
@herbsjs-robot
Copy link

🎉 This PR is included in version 1.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@herbsjs-robot herbsjs-robot added the released Already in production label Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Already in production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants