Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change component_name to app_id #2802

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

change component_name to app_id #2802

wants to merge 3 commits into from

Conversation

angeldcampbell
Copy link
Contributor

@angeldcampbell angeldcampbell commented Apr 12, 2024

We were accidentally sending the component name, not app_id on this request, just fixes that in the workflow

@angeldcampbell angeldcampbell marked this pull request as ready for review April 16, 2024 21:37
@angeldcampbell angeldcampbell requested a review from a team as a code owner April 16, 2024 21:37
Copy link
Contributor

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving because the change from component_name to app_id looks correct, but take a look to my comment. I believe you missed to do the same path change on the step for retries.

@@ -18,8 +18,8 @@ jobs:
-H "Accept: application/json" \
-H "Content-Type: application/json" \
-H "Authorization: Token ${{ secrets.TPS_API_TOKEN_PARAM }}" \
-d '{"lock": {"sha": "${{ github.sha }}", "component_name": "${{ secrets.TPS_API_APP_ID }}"}}' \
${{ secrets.TPS_API_URL_PARAM }}/api/ctc`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you removed the path /api/ctc here. Was that moved to the URL set in the secrets? In that case I believe you need to do the same for retries on line 45 below because it still has that path set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants