refactor: migrate run commands to use oclif/core v2 #2880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item
This command migrates the run commands (
run
,run:detached
, andrun:inside
) to oclif/core v2 (they were previously using v1) and deletes the run-v5 package.Notes
Migrating these commands to oclif/core v2 means that users will need to add additional flags that they wish to run inside their dynos after a double dash (
--
). So, for example, where a user could have previously run the commandheroku run bash --norc -a APP_NAME
, they will now need to runheroku run bash -a APP_NAME -- --norc
with the additional commands both at the end of the command and after a double dash.There was also a report that when this update was made previously a user was having the order of their additional commands reversed. This was apparently fixed by downgrading the command to use oclif/core v1. I was unable to reproduce this error in the oclif/core v2 version, but it is an issue that may come up.
Testing
yarn
andyarn build
run:inside
you'll need to use an app that exists inside a private space.run
./bin/run run bash --norc -a APP_NAME
./bin/run run bash -a APP_NAME -- --norc
./bin/run run bash -a APP_NAME -- --norc --verbose
run:detached
./bin/run run:detached ls -a APP_NAME
ls
is running on your app with a logs command to view the outputrun:inside
dyno-run-inside
../bin/run run:inside -a APP_NAME web.1 bash