Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): Remove plugins 'oauth-v5' and 'certs-v5' from prerelease branch #2881

Merged
merged 3 commits into from
May 14, 2024

Conversation

sbosio
Copy link
Contributor

@sbosio sbosio commented May 13, 2024

Description

This PR removes plugins oauth-v5 and certs-v5 from the prerelease branch.

Plugin oauth-v5 was kept when the commands were migrated to OClif/TS to have a quick around restoring the functionality in case something went wrong, but things have been working for months without issues now.

Plugin 'certs-v5' was kept around while a decision was made on the two broken commands certs:chain and certs:key. We have decided to remove those commands on v9.x series, so it was time to remove the old plugin from the repo.

SOC2 Compliance

GUS Work Item (Heroku internal)
Slack thread

@sbosio sbosio requested a review from a team as a code owner May 13, 2024 19:04
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Thank you!

packages/cli/README.md Show resolved Hide resolved
@sbosio sbosio temporarily deployed to AcceptanceTests May 14, 2024 22:23 — with GitHub Actions Inactive
@sbosio sbosio temporarily deployed to AcceptanceTests May 14, 2024 22:23 — with GitHub Actions Inactive
@sbosio sbosio merged commit 0e1640b into prerelease/9.0.0-alpha May 14, 2024
7 checks passed
@sbosio sbosio deleted the sbosio/remove-oauth-v5 branch May 14, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants